Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Support project names starting with gz- #246

Merged
merged 2 commits into from
May 4, 2022
Merged

Conversation

scpeters
Copy link
Member

@scpeters scpeters commented May 3, 2022

🎉 New feature

Part of gazebo-tooling/release-tools#718 and s subset of #239 that supports project names starting with gz-

Summary

There are quite a few changes in #239, but I'm not sure about all of them, so I split out the support for project names starting with gz- into this pull request (with a slightly different implementation).

Test it

I've tested this a bit with gazebosim/gz-utils#57 and gazebosim/gz-math#420 (without the gz-cmake3 project name), and it seems to be working.

Checklist

  • Signed all commits for DCO
  • Added tests
  • Added example and/or tutorial
  • Updated documentation (as needed)
  • Updated migration guide (as needed)
  • Consider updating Python bindings (if the library has them)
  • codecheck passed (See contributing)
  • All tests passed (See test coverage)
  • While waiting for a review on your PR, please help review another open pull request to support the maintainers

Note to maintainers: Remember to use Squash-Merge and edit the commit message to match the pull request summary while retaining Signed-off-by messages.

Copy link
Contributor

@chapulina chapulina left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Works as advertised. I just have one suggestion that should make it easier to completely remove ignition later.

cmake/IgnConfigureProject.cmake Outdated Show resolved Hide resolved
@chapulina chapulina added the ign to gz Renaming Ignition to Gazebo. label May 3, 2022
@scpeters scpeters merged commit 7d95a11 into main May 4, 2022
@scpeters scpeters deleted the scpeters/gz_project_name branch May 4, 2022 00:47
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
🌱 garden Ignition Garden ign to gz Renaming Ignition to Gazebo.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants