Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Deprecate ign_manual_search, ign_create_packages, ign_create_core_library #255

Merged
merged 7 commits into from
May 17, 2022
Merged

Deprecate ign_manual_search, ign_create_packages, ign_create_core_library #255

Show file tree
Hide file tree
Changes from 1 commit
Commits
Show all changes
7 commits
Select commit Hold shift + click to select a range
8b6c62c
ign_manual_search
chapulina May 9, 2022
2b95760
ign_create_packages
chapulina May 9, 2022
a074e5a
ign_create_core_library
chapulina May 9, 2022
7923d0e
Merge branch 'main' into chapulina/3/ign_deprecations_3
scpeters May 14, 2022
1a87c1a
Merge branch 'main' into chapulina/3/ign_deprecations_3
chapulina May 16, 2022
4df8477
Apply suggestions from code review
chapulina May 16, 2022
9ae1039
Merge branch 'main' into chapulina/3/ign_deprecations_3
scpeters May 17, 2022
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
8 changes: 7 additions & 1 deletion cmake/IgnPackaging.cmake
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -7,7 +7,7 @@
# Sets up package information for an ignition library project.
# This function is internal to gz-cmake.
#
# ign_create_package
# gz_create_packages
#
# Creates a package for an ignition library project
#
Expand Down Expand Up @@ -148,6 +148,12 @@ macro(_gz_setup_packages)
endmacro()

macro(ign_create_packages)
# TODO(chapulina) Enable warnings after all libraries have migrated.
# message(WARNING "ign_create_packages is deprecated, use gz_create_packages instead.")

gz_create_packages()
endmacro()
macro(gz_create_packages)

#============================================================================
# Load platform-specific build hooks if present.
chapulina marked this conversation as resolved.
Show resolved Hide resolved
Expand Down
2 changes: 1 addition & 1 deletion examples/comp_deps/CMakeLists.txt
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -4,5 +4,5 @@ find_package(ignition-cmake3 REQUIRED)
ign_configure_project()
ign_configure_build(QUIT_IF_BUILD_ERRORS
COMPONENTS child parent)
ign_create_packages()
gz_create_packages()
ign_create_docs()
2 changes: 1 addition & 1 deletion examples/core_child/CMakeLists.txt
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -4,5 +4,5 @@ find_package(ignition-cmake3 REQUIRED)
ign_configure_project()
ign_find_package(ignition-core_no_deps REQUIRED)
ign_configure_build(QUIT_IF_BUILD_ERRORS)
ign_create_packages()
gz_create_packages()
ign_create_docs(TAGFILES "${IGNITION-CORE_NO_DEPS_DOXYGEN_TAGFILE} = ${IGNITION-CORE_NO_DEPS_API_URL}")
2 changes: 1 addition & 1 deletion examples/core_child_private/CMakeLists.txt
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -4,5 +4,5 @@ find_package(ignition-cmake3 REQUIRED)
ign_configure_project()
ign_find_package(ignition-core_no_deps PRIVATE REQUIRED)
ign_configure_build(QUIT_IF_BUILD_ERRORS)
ign_create_packages()
gz_create_packages()
ign_create_docs(TAGFILES "${IGNITION-CORE_NO_DEPS_DOXYGEN_TAGFILE} = ${IGNITION-CORE_NO_DEPS_API_URL}")
2 changes: 1 addition & 1 deletion examples/core_nodep/CMakeLists.txt
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -3,5 +3,5 @@ project(ignition-core_no_deps VERSION 0.1.0)
find_package(ignition-cmake3 REQUIRED)
ign_configure_project()
ign_configure_build(QUIT_IF_BUILD_ERRORS)
ign_create_packages()
gz_create_packages()
ign_create_docs()
2 changes: 1 addition & 1 deletion examples/core_nodep_static/CMakeLists.txt
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -4,5 +4,5 @@ find_package(ignition-cmake3 REQUIRED)
ign_configure_project()
OPTION(BUILD_SHARED_LIBS OFF)
ign_configure_build(QUIT_IF_BUILD_ERRORS)
ign_create_packages()
gz_create_packages()
ign_create_docs()
2 changes: 1 addition & 1 deletion examples/core_static_child/CMakeLists.txt
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -4,5 +4,5 @@ find_package(ignition-cmake3 REQUIRED)
ign_configure_project()
ign_find_package(ignition-core_no_deps_static REQUIRED)
ign_configure_build(QUIT_IF_BUILD_ERRORS)
ign_create_packages()
gz_create_packages()
ign_create_docs(TAGFILES "${IGNITION-CORE_NO_DEPS_STATIC_DOXYGEN_TAGFILE} = ${IGNITION-CORE_NO_DEPS_STATIC_API_URL}")
2 changes: 1 addition & 1 deletion examples/no_ignition_prefix/CMakeLists.txt
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -5,5 +5,5 @@ ign_configure_project(
NO_IGNITION_PREFIX
REPLACE_IGNITION_INCLUDE_PATH no_ign)
ign_configure_build(QUIT_IF_BUILD_ERRORS)
ign_create_packages()
gz_create_packages()
ign_create_docs()
2 changes: 1 addition & 1 deletion examples/use_component_depsA/CMakeLists.txt
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -4,5 +4,5 @@ find_package(ignition-cmake3 REQUIRED)
ign_configure_project()
ign_find_package(ignition-component_deps REQUIRED COMPONENTS parent child)
ign_configure_build(QUIT_IF_BUILD_ERRORS)
ign_create_packages()
gz_create_packages()
ign_create_docs()
2 changes: 1 addition & 1 deletion examples/use_component_depsB/CMakeLists.txt
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -4,5 +4,5 @@ find_package(ignition-cmake3 REQUIRED)
ign_configure_project()
ign_find_package(ignition-component_deps REQUIRED COMPONENTS child parent)
ign_configure_build(QUIT_IF_BUILD_ERRORS)
ign_create_packages()
gz_create_packages()
ign_create_docs()
2 changes: 1 addition & 1 deletion examples/use_component_depsC/CMakeLists.txt
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -4,5 +4,5 @@ find_package(ignition-cmake3 REQUIRED)
ign_configure_project()
ign_find_package(ignition-component_deps REQUIRED COMPONENTS child)
ign_configure_build(QUIT_IF_BUILD_ERRORS)
ign_create_packages()
gz_create_packages()
ign_create_docs()
2 changes: 1 addition & 1 deletion examples/use_config_ifp/CMakeLists.txt
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -19,4 +19,4 @@ else()
endif()
ign_configure_project()
ign_configure_build(QUIT_IF_BUILD_ERRORS)
ign_create_packages()
gz_create_packages()