Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Change EXTRA_ARGS to be a multiValueArgs in GzFindPackage #393

Merged
merged 2 commits into from
Nov 2, 2023

Conversation

j-rivero
Copy link
Contributor

@j-rivero j-rivero commented Nov 1, 2023

🦟 Bug fix

Fixes #391

Summary

EXTRA_ARGS should really be a multiValueArgs as explained in the issue.

Checklist

  • Signed all commits for DCO
  • Added tests
  • Updated documentation (as needed)
  • Updated migration guide (as needed)
  • Consider updating Python bindings (if the library has them)
  • codecheck passed (See contributing)
  • All tests passed (See test coverage)
  • While waiting for a review on your PR, please help review another open pull request to support the maintainers

Note to maintainers: Remember to use Squash-Merge and edit the commit message to match the pull request summary while retaining Signed-off-by messages.

@github-actions github-actions bot added 🌱 garden Ignition Garden 🎵 harmonic Gazebo Harmonic labels Nov 1, 2023
scpeters added a commit that referenced this pull request Nov 2, 2023
This should fail without the fix in #393.

Signed-off-by: Steve Peters <[email protected]>
@scpeters
Copy link
Member

scpeters commented Nov 2, 2023

I've added a small test in #394, which I expect to fail in that draft PR, and if you cherry-pick it to this branch I expect it to pass. 🤞

@scpeters
Copy link
Member

scpeters commented Nov 2, 2023

I've added a small test in #394, which I expect to fail in that draft PR, and if you cherry-pick it to this branch I expect it to pass. 🤞

a cmake warning was generated in CI for #394 as expected:

Build Status https://build.osrfoundation.org/job/gz_cmake-ci-pr_any-jammy-amd64/47/cmake/

please consider cherry-picking that test change into this branch

This should fail without the fix in #393.

Signed-off-by: Steve Peters <[email protected]>
@j-rivero
Copy link
Contributor Author

j-rivero commented Nov 2, 2023

please consider cherry-picking that test change into this branch

Thanks so much for the test. Already cherry-picked.

@scpeters scpeters merged commit 40db6b2 into gz-cmake3 Nov 2, 2023
6 checks passed
@scpeters scpeters deleted the jrivero/extra_args_multivalue branch November 2, 2023 16:39
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
🌱 garden Ignition Garden 🎵 harmonic Gazebo Harmonic
Projects
Archived in project
Development

Successfully merging this pull request may close these issues.

EXTRA_ARGS should be a multi-value arg
2 participants