Fix how ign compatibility files are copied in windows
#419
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Instead of relying on the installed `gz` cmake file, we copy the one from the source directory. This avoids relying on an absolute path formed using `CMAKE_INSTALL_PREFIX`, which doesn't work well when using `CMAKE_STAGING_PREFIX`. Signed-off-by: Addisu Z. Taddese <[email protected]>
scpeters
approved these changes
Mar 29, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
🦟 Bug fix
Summary
Instead of relying on the installed
gzcmake file, we copy the one from the source directory. This avoids relying on an absolute path formed usingCMAKE_INSTALL_PREFIX, which doesn't work well when usingCMAKE_STAGING_PREFIX.This is needed to fix windows build failure of
gz_cmake_vendor. https://ci.ros2.org/job/ci_windows/21361/console#console-section-25Checklist
codecheckpassed (See contributing)Note to maintainers: Remember to use Squash-Merge and edit the commit message to match the pull request summary while retaining
Signed-off-bymessages.