Fix installation of Ign*.cmake
modules on newer versions of CMake
#425
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
🦟 Bug fix
Summary
Previously, we expected
install(CODE ...)
, to run beforeinstall(FILES ...)
since that is the order they appear in the CMakeLists.txt file.install(CODE ...)
was responsible for creating a copy or symlink ofGz*.cmake
files toIgn*.cmake
and putting them in a temporary location.
install(FILES ...)
would then copy those files to the final install destination. However, it appears that on CMake 3.29.2 (tested on windows), we can no longer rely on the order they appear in the code. From my local testing,install(CODE ...)
ran afterinstall(FILES ...)
.This PR uses
add_custom_command
to generate theIgn*.cmake
files which avoids any reliance on the order of theinstall
calls.This was caught during the ROS 2 tutorial party (see osrf/ros2_test_cases#1526)
cc @clalancette
Checklist
codecheck
passed (See contributing)Note to maintainers: Remember to use Squash-Merge and edit the commit message to match the pull request summary while retaining
Signed-off-by
messages.