-
Notifications
You must be signed in to change notification settings - Fork 31
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Accept arbitrary capitalization for coverage build type #435
Conversation
Signed-off-by: Addisu Z. Taddese <[email protected]>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I tried to reproduce the warning in #437 but found that our test builds of the examples have the possibility of using the Coverage
build type, but it doesn't ever seem to happen in our CI because lcov
isn't installed, but this change looks good to me so I'll approve it
FYI, you can see the warning in https://github.com/gazebosim/gz-fuel-tools/actions/runs/10014645331/job/27684714954?pr=427 if you expand the |
@Mergifyio backport gz-cmake3 ign-cmake2 |
✅ Backports have been created
|
Signed-off-by: Addisu Z. Taddese <[email protected]> (cherry picked from commit 916a917)
Signed-off-by: Addisu Z. Taddese <[email protected]> (cherry picked from commit 916a917)
Signed-off-by: Addisu Z. Taddese <[email protected]> (cherry picked from commit 916a917)
Signed-off-by: Addisu Z. Taddese <[email protected]> (cherry picked from commit 916a917)
🦟 Bug fix
Summary
When running
cmake -DCMAKE_BUILD_TYPE=coverage
(which most of our CI does), gz-cmake generates a warningThis is only because we are specifically looking for
Coverage
, with uppercaseC
. This patch makes it possible to pass any capitalization of the word.Checklist
codecheck
passed (See contributing)Note to maintainers: Remember to use Squash-Merge and edit the commit message to match the pull request summary while retaining
Signed-off-by
messages.