Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Accept arbitrary capitalization for coverage build type #435

Merged
merged 1 commit into from
Jul 22, 2024

Conversation

azeey
Copy link
Contributor

@azeey azeey commented Jul 20, 2024

🦟 Bug fix

Summary

When running cmake -DCMAKE_BUILD_TYPE=coverage (which most of our CI does), gz-cmake generates a warning

Code coverage results with an optimized (non-Debug) build may be misleading

This is only because we are specifically looking for Coverage, with uppercase C. This patch makes it possible to pass any capitalization of the word.

Checklist

  • Signed all commits for DCO
  • Added tests
  • Updated documentation (as needed)
  • Updated migration guide (as needed)
  • Consider updating Python bindings (if the library has them)
  • codecheck passed (See contributing)
  • All tests passed (See test coverage)
  • While waiting for a review on your PR, please help review another open pull request to support the maintainers

Note to maintainers: Remember to use Squash-Merge and edit the commit message to match the pull request summary while retaining Signed-off-by messages.

Copy link
Member

@scpeters scpeters left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I tried to reproduce the warning in #437 but found that our test builds of the examples have the possibility of using the Coverage build type, but it doesn't ever seem to happen in our CI because lcov isn't installed, but this change looks good to me so I'll approve it

@azeey
Copy link
Contributor Author

azeey commented Jul 22, 2024

FYI, you can see the warning in https://github.com/gazebosim/gz-fuel-tools/actions/runs/10014645331/job/27684714954?pr=427 if you expand the cmake section. And this has been the case for older versions of gz-cmake as well.

@azeey azeey merged commit 916a917 into gazebosim:main Jul 22, 2024
10 checks passed
@azeey azeey deleted the coverage_capitalization branch July 22, 2024 15:06
@azeey
Copy link
Contributor Author

azeey commented Jul 22, 2024

@Mergifyio backport gz-cmake3 ign-cmake2

Copy link

mergify bot commented Jul 22, 2024

backport gz-cmake3 ign-cmake2

✅ Backports have been created

mergify bot pushed a commit that referenced this pull request Jul 22, 2024
Signed-off-by: Addisu Z. Taddese <[email protected]>
(cherry picked from commit 916a917)
mergify bot pushed a commit that referenced this pull request Jul 22, 2024
Signed-off-by: Addisu Z. Taddese <[email protected]>
(cherry picked from commit 916a917)
azeey added a commit that referenced this pull request Jul 22, 2024
Signed-off-by: Addisu Z. Taddese <[email protected]>
(cherry picked from commit 916a917)
azeey added a commit that referenced this pull request Jul 22, 2024
Signed-off-by: Addisu Z. Taddese <[email protected]>
(cherry picked from commit 916a917)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
🏛️ ionic Gazebo Ionic
Projects
Archived in project
Development

Successfully merging this pull request may close these issues.

2 participants