Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use HIDE_SYMBOLS_BY_DEFAULT #551

Closed
wants to merge 1 commit into from
Closed

Conversation

scpeters
Copy link
Member

@scpeters scpeters commented Nov 8, 2023

🎉 New feature

Part of testing gazebosim/gz-cmake#392.

Summary

Test it

Checklist

  • Signed all commits for DCO
  • Added tests
  • Added example and/or tutorial
  • Updated documentation (as needed)
  • Updated migration guide (as needed)
  • Consider updating Python bindings (if the library has them)
  • codecheck passed (See contributing)
  • All tests passed (See test coverage)
  • While waiting for a review on your PR, please help review another open pull request to support the maintainers

Note to maintainers: Remember to use Squash-Merge and edit the commit message to match the pull request summary while retaining Signed-off-by messages.

Part of testing gazebosim/gz-cmake#392.

Signed-off-by: Steve Peters <[email protected]>
@scpeters scpeters requested a review from marcoag as a code owner November 8, 2023 03:23
Copy link

codecov bot commented Nov 8, 2023

Codecov Report

Merging #551 (64b55bb) into main (a52a7d2) will not change coverage.
The diff coverage is n/a.

❗ Current head 64b55bb differs from pull request most recent head c4c6e48. Consider uploading reports for the commit c4c6e48 to get more accurate results

@@           Coverage Diff           @@
##             main     #551   +/-   ##
=======================================
  Coverage   83.63%   83.63%           
=======================================
  Files          79       79           
  Lines       10213    10213           
=======================================
  Hits         8542     8542           
  Misses       1671     1671           

@scpeters
Copy link
Member Author

scpeters commented Nov 9, 2023

duplicate of #549

@scpeters scpeters closed this Nov 9, 2023
@scpeters scpeters deleted the scpeters/hide_symbols_by_default branch November 9, 2023 05:03
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Archived in project
Development

Successfully merging this pull request may close these issues.

1 participant