Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Multiple memory cleanup fixes #571

Merged
merged 10 commits into from
Jan 29, 2024
Merged

Multiple memory cleanup fixes #571

merged 10 commits into from
Jan 29, 2024

Conversation

mjcarroll
Copy link
Contributor

@mjcarroll mjcarroll commented Jan 16, 2024

🦟 Bug fix

Summary

Clean up remaining memory issues found with ASAN. Unblocks some work on #569.

This fixes all asan issues except for one in AudioDecoder, which I'm going to skip for now. I'm not convinced audio decoder is really doing the right thing (or the useful thing), and there are no downstream users for it.

Note to maintainers: Remember to use Squash-Merge and edit the commit message to match the pull request summary while retaining Signed-off-by messages.

@mjcarroll mjcarroll requested a review from marcoag as a code owner January 16, 2024 17:41
@github-actions github-actions bot added 🌱 garden Ignition Garden 🎵 harmonic Gazebo Harmonic labels Jan 16, 2024
Signed-off-by: Michael Carroll <[email protected]>
Signed-off-by: Michael Carroll <[email protected]>
@mjcarroll mjcarroll changed the title Mjcarroll/asan Multiple memory cleanup fixes Jan 16, 2024
Copy link

codecov bot commented Jan 16, 2024

Codecov Report

Attention: 2 lines in your changes are missing coverage. Please review.

Comparison is base (0b8428a) 83.65% compared to head (abcf273) 83.65%.
Report is 1 commits behind head on gz-common5.

❗ Current head abcf273 differs from pull request most recent head eaf8e3e. Consider uploading reports for the commit eaf8e3e to get more accurate results

Files Patch % Lines
graphics/src/Image.cc 66.66% 2 Missing ⚠️
Additional details and impacted files
@@              Coverage Diff               @@
##           gz-common5     #571      +/-   ##
==============================================
- Coverage       83.65%   83.65%   -0.01%     
==============================================
  Files              90       92       +2     
  Lines           10273    10285      +12     
==============================================
+ Hits             8594     8604      +10     
- Misses           1679     1681       +2     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@mjcarroll mjcarroll marked this pull request as draft January 16, 2024 18:24
@mjcarroll
Copy link
Contributor Author

Still chasing one or two more here.

@mjcarroll mjcarroll marked this pull request as ready for review January 18, 2024 19:48
@mjcarroll
Copy link
Contributor Author

@osrf-jenkins retest this please

@mjcarroll mjcarroll mentioned this pull request Jan 18, 2024
3 tasks
@mjcarroll mjcarroll self-assigned this Jan 29, 2024
@mjcarroll mjcarroll merged commit bc24ece into gz-common5 Jan 29, 2024
13 checks passed
@mjcarroll mjcarroll deleted the mjcarroll/asan branch January 29, 2024 16:09
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
🌱 garden Ignition Garden 🎵 harmonic Gazebo Harmonic
Projects
Archived in project
Development

Successfully merging this pull request may close these issues.

3 participants