-
Notifications
You must be signed in to change notification settings - Fork 42
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Multiple memory cleanup fixes #571
Conversation
Signed-off-by: Michael Carroll <[email protected]>
Signed-off-by: Michael Carroll <[email protected]>
Signed-off-by: Michael Carroll <[email protected]>
Signed-off-by: Michael Carroll <[email protected]>
Signed-off-by: Michael Carroll <[email protected]>
Codecov ReportAttention:
Additional details and impacted files@@ Coverage Diff @@
## gz-common5 #571 +/- ##
==============================================
- Coverage 83.65% 83.65% -0.01%
==============================================
Files 90 92 +2
Lines 10273 10285 +12
==============================================
+ Hits 8594 8604 +10
- Misses 1679 1681 +2 ☔ View full report in Codecov by Sentry. |
Still chasing one or two more here. |
Signed-off-by: Michael Carroll <[email protected]>
@osrf-jenkins retest this please |
🦟 Bug fix
Summary
Clean up remaining memory issues found with ASAN. Unblocks some work on #569.
This fixes all asan issues except for one in
AudioDecoder
, which I'm going to skip for now. I'm not convinced audio decoder is really doing the right thing (or the useful thing), and there are no downstream users for it.Note to maintainers: Remember to use Squash-Merge and edit the commit message to match the pull request summary while retaining
Signed-off-by
messages.