Merge ign-common4 ➡️ gz-common5 #572
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Zaidhaan Hussain <[email protected]>
Signed-off-by: Angelo Elias Dal Zotto <[email protected]>
Signed-off-by: Michael Carroll <[email protected]>
Signed-off-by: Jose Luis Rivero <[email protected]>
* fix: Don't recursively call init if log directories can not be created. If there is no permission to create the log directories, the FileLogger will call itself recutsive, as is used ignerr for logging the error, which will call FileLogger::Init again. This commit fixed this, by using std::cerr for the log output in FileLogger::Init. Signed-off-by: Janosch Machowinski <[email protected]> Co-authored-by: Ian Chen <[email protected]>
* Use on `push` only on stable branches to avoid duplicate runs * Update project automation Signed-off-by: Addisu Z. Taddese <[email protected]>
Signed-off-by: Michael Carroll <[email protected]>
Signed-off-by: Addisu Z. Taddese <[email protected]>
Merge ign-common3 ➡️ ign-common4
Signed-off-by: Michael Carroll <[email protected]>
Signed-off-by: Addisu Z. Taddese <[email protected]>
Merge ign-common3 ➡️ ign-common4
Signed-off-by: Addisu Z. Taddese <[email protected]>
|
@mjcarroll I couldn't properly port #561 since a lot has changed. Is it needed for gz-common5? |
|
No, it's no longer necessary as we changed how the filesystem functions warn when switching to std::filesystem. |
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## gz-common5 #572 +/- ##
===========================================
Coverage 83.65% 83.65%
===========================================
Files 90 90
Lines 10273 10273
===========================================
Hits 8594 8594
Misses 1679 1679 ☔ View full report in Codecov by Sentry. |
mjcarroll
approved these changes
Jan 18, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
➡️ Forward port
Port
ign-common4➡️gz-common5Branch comparison: gz-common5...ign-common4
Note to maintainers: Remember to Merge with commit (not squash-merge or rebase)