Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Extend AssimpLoader to parse material transmission factor #577

Merged
merged 4 commits into from
Mar 4, 2024

Conversation

iche033
Copy link
Contributor

@iche033 iche033 commented Mar 1, 2024

🎉 New feature

Summary

Adds basic support for material transmission extension.

Transmission can be used to simulate effects like tinting and refraction. Here we are currently just parsing the transmission factor property and modeling it as simple transparency setting.

Test it

Tested with the AnisotropyBarnLamp.glb model. The bulb part of the mesh is now transparent (previously just opaque white as shown in gazebosim/gz-rendering#976):

lamp_transmission

Checklist

  • Signed all commits for DCO
  • Added tests
  • Added example and/or tutorial
  • Updated documentation (as needed)
  • Updated migration guide (as needed)
  • Consider updating Python bindings (if the library has them)
  • codecheck passed (See contributing)
  • All tests passed (See test coverage)
  • While waiting for a review on your PR, please help review another open pull request to support the maintainers

Note to maintainers: Remember to use Squash-Merge and edit the commit message to match the pull request summary while retaining Signed-off-by messages.

@iche033 iche033 requested a review from marcoag as a code owner March 1, 2024 22:59
@github-actions github-actions bot added 🌱 garden Ignition Garden 🎵 harmonic Gazebo Harmonic labels Mar 1, 2024
@iche033 iche033 requested a review from shameekganguly March 1, 2024 23:00
iche033 added 2 commits March 1, 2024 23:56
Signed-off-by: Ian Chen <[email protected]>
Signed-off-by: Ian Chen <[email protected]>
Copy link

codecov bot commented Mar 2, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 83.66%. Comparing base (3571cb4) to head (ade42a8).

Additional details and impacted files
@@             Coverage Diff             @@
##           gz-common5     #577   +/-   ##
===========================================
  Coverage       83.65%   83.66%           
===========================================
  Files              92       92           
  Lines           10287    10288    +1     
===========================================
+ Hits             8606     8607    +1     
  Misses           1681     1681           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@mjcarroll mjcarroll merged commit b3ba7ab into gz-common5 Mar 4, 2024
15 checks passed
@mjcarroll mjcarroll deleted the assimp_transmission branch March 4, 2024 15:13
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
🌱 garden Ignition Garden 🎵 harmonic Gazebo Harmonic
Projects
Archived in project
Development

Successfully merging this pull request may close these issues.

3 participants