Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Clean up Clang compiler warnings #589

Merged
merged 5 commits into from
Mar 28, 2024
Merged

Conversation

mjcarroll
Copy link
Contributor

Cleans up three sets of warnings:

  • There were a few unnecessary std::move calls
  • Adds a copy assignment operator to CSVIterator to fulfill rule-of-three
  • Suppress some warnings in the vendored remotery code via CMake.

Signed-off-by: Michael Carroll <[email protected]>
Signed-off-by: Michael Carroll <[email protected]>
@mjcarroll mjcarroll self-assigned this Mar 27, 2024
@mjcarroll mjcarroll requested a review from marcoag as a code owner March 27, 2024 15:15
Copy link

codecov bot commented Mar 27, 2024

Codecov Report

Attention: Patch coverage is 14.28571% with 6 lines in your changes are missing coverage. Please review.

Project coverage is 80.54%. Comparing base (038e2f7) to head (a57ce65).

Files Patch % Lines
io/src/CSVStreams.cc 14.28% 6 Missing ⚠️
Additional details and impacted files
@@           Coverage Diff           @@
##             main     #589   +/-   ##
=======================================
  Coverage   80.54%   80.54%           
=======================================
  Files          80       80           
  Lines       13573    13579    +6     
=======================================
+ Hits        10932    10937    +5     
- Misses       2641     2642    +1     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Signed-off-by: Michael Carroll <[email protected]>
Signed-off-by: Michael Carroll <[email protected]>
@mjcarroll mjcarroll requested a review from iche033 March 27, 2024 19:53
@mjcarroll mjcarroll merged commit 149339c into main Mar 28, 2024
9 of 10 checks passed
@mjcarroll mjcarroll deleted the mjcarroll/minor_compiler_warnings branch March 28, 2024 12:58
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
Archived in project
Development

Successfully merging this pull request may close these issues.

3 participants