5 ➡️ 3 - EnumIface: suppress deprecation warning (#540) #601
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The EnumIterator inherits from std::iterator, which has been deprecated in c++17. There is a fix in gz-common6 but it breaks API, so it can't be merged to Garden. So just suppress the deprecation warning in Garden. Signed-off-by: Steve Peters <[email protected]>
azeey
requested changes
Apr 25, 2024
| @@ -140,6 +140,7 @@ namespace ignition | |||
| /// std::cout << "Type++ Name[" << myTypeIface.Str(*i) << "]\n"; | |||
| /// } | |||
| /// \verbatim | |||
| GZ_UTILS_WARN_IGNORE__DEPRECATED_DECLARATION | |||
There was a problem hiding this comment.
You'll need to include https://github.com/gazebosim/gz-cmake/blob/ign-cmake2/include/gz/utilities/SuppressWarning.hh and use the IGN prefix. Note that this version of gz-common didn't have a dependency on gz-utils. However, the warning suppression utilities are available in gz-cmake2.
|
I didn't realize the |
|
#603 is merged, so I'll close this. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
🦟 Bug fix
Fixes #505
Summary
Backport of #540
Checklist
codecheckpassed (See contributing)Note to maintainers: Remember to use Squash-Merge and edit the commit message to match the pull request summary while retaining
Signed-off-bymessages.