Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Use HIDE_SYMBOLS_BY_DEFAULT #389

Merged
merged 1 commit into from
Nov 16, 2023
Merged

Use HIDE_SYMBOLS_BY_DEFAULT #389

merged 1 commit into from
Nov 16, 2023

Conversation

scpeters
Copy link
Member

🎉 New feature

Part of testing gazebosim/gz-cmake#392.

Summary

Test it

Checklist

  • Signed all commits for DCO
  • Added tests
  • Added example and/or tutorial
  • Updated documentation (as needed)
  • Updated migration guide (as needed)
  • Consider updating Python bindings (if the library has them)
  • codecheck passed (See contributing)
  • All tests passed (See test coverage)
  • While waiting for a review on your PR, please help review another open pull request to support the maintainers

Note to maintainers: Remember to use Squash-Merge and edit the commit message to match the pull request summary while retaining Signed-off-by messages.

@scpeters
Use HIDE_SYMBOLS_BY_DEFAULT
68260f4 
Part of testing gazebosim/gz-cmake#392.

Signed-off-by: Steve Peters <[email protected]>

Signed-off-by: Steve Peters <[email protected]>
@scpeters scpeters requested a review from nkoenig as a code owner November 13, 2023 18:08
j-rivero
j-rivero approved these changes Nov 16, 2023
View reviewed changes
Copy link
Contributor

@j-rivero j-rivero left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

tests problems seems unrelated

@scpeters scpeters merged commit 1e0a69d into main Nov 16, 2023
8 of 9 checks passed
@scpeters scpeters deleted the scpeters/hide_symbols_by_default branch November 16, 2023 19:05
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@j-rivero j-rivero j-rivero approved these changes

@nkoenig nkoenig Awaiting requested review from nkoenig nkoenig is a code owner

@mjcarroll mjcarroll Awaiting requested review from mjcarroll

Assignees
No one assigned
Labels
None yet
Projects
Core development
Archived in project
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@scpeters @j-rivero