Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Create directories and more output on fail #392

Merged
merged 3 commits into from
Dec 11, 2023
Merged

Create directories and more output on fail #392

merged 3 commits into from
Dec 11, 2023

Conversation

mjcarroll
Copy link
Contributor

More output to catch #391

@mjcarroll mjcarroll requested a review from nkoenig as a code owner November 27, 2023 14:08
@mjcarroll mjcarroll self-assigned this Nov 27, 2023
@github-actions github-actions bot added the 🏰 citadel Ignition Citadel label Nov 27, 2023
@mjcarroll
Backpack and teambase version bumps
1233a6f 
Signed-off-by: Michael Carroll <[email protected]>
@mjcarroll
More model updates
db9f2f9 
Signed-off-by: Michael Carroll <[email protected]>
@mjcarroll
Copy link
Contributor Author

@j-rivero something weird happening in CI Windows here:

# BEGIN SECTION: get open robotics deps (ign-fuel-tools4.yaml) sources into the workspace
Cloning into 'gazebodistro'...
mjcarroll/more_output_on_fail does not match ci_matching_branch/
The system cannot find the drive specified.
branch name mjcarroll/more_output_on_fail is not a match
* master
Input data is not valid format: string indices must be integers, not 'str'
Failed in windows_library with error #1.
Build step 'Execute Windows batch command' marked build as failure

@mjcarroll
Copy link
Contributor Author

Waiting on: gazebo-tooling/release-tools#1083 for clean Windows build

@j-rivero
Copy link
Contributor

@osrf-jenkins run tests

@azeey
Copy link
Contributor

azeey commented Nov 30, 2023

Windows is failing. Retrying it in case it's a network issue.

@mjcarroll mjcarroll mentioned this pull request Dec 4, 2023
Merged
@mjcarroll
Copy link
Contributor Author

@osrf-jenkins retest this please

@mjcarroll
Copy link
Contributor Author

@osrf-jenkins retest this please

(I think that the focal and homebrew failures are flakes, they both had timeouts)

@mjcarroll
Copy link
Contributor Author

@osrf-jenkins retest this please

@mjcarroll
Copy link
Contributor Author

I think the failures from the last round were network flakes, this should be good to go now.

@mjcarroll mjcarroll merged commit b80abc3 into ign-fuel-tools4 Dec 11, 2023
13 checks passed
@mjcarroll mjcarroll deleted the mjcarroll/more_output_on_fail branch December 11, 2023 17:37
@mjcarroll mjcarroll mentioned this pull request Dec 11, 2023
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ahcorde ahcorde ahcorde approved these changes

@nkoenig nkoenig Awaiting requested review from nkoenig nkoenig is a code owner

Assignees

@mjcarroll mjcarroll

Labels
🏰 citadel Ignition Citadel
Projects
Core development
Archived in project
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@mjcarroll @j-rivero @azeey @ahcorde