-
Notifications
You must be signed in to change notification settings - Fork 21
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
CLI for creating config.yaml #413
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Nate Koenig <[email protected]>
Signed-off-by: Nate Koenig <[email protected]>
Signed-off-by: Nate Koenig <[email protected]>
ahcorde
requested changes
Apr 10, 2024
Signed-off-by: Nate Koenig <[email protected]>
Signed-off-by: Nate Koenig <[email protected]>
Signed-off-by: Nate Koenig <[email protected]>
@ahcorde , can I get a quick re-review please? All the tests are now passing. |
ahcorde
approved these changes
Apr 25, 2024
azeey
added a commit
to gazebo-release/gz-fuel-tools9-release
that referenced
this pull request
Aug 7, 2024
The config.yaml is no longer installed by the upstream code as of gazebosim/gz-fuel-tools#413 Signed-off-by: Addisu Z. Taddese <[email protected]>
azeey
added a commit
to gazebo-release/gz-fuel-tools9-release
that referenced
this pull request
Aug 7, 2024
…#3) The config.yaml is no longer installed by the upstream code as of gazebosim/gz-fuel-tools#413 Signed-off-by: Addisu Z. Taddese <[email protected]>
j-rivero
added a commit
to gazebo-release/gz-fuel-tools8-release
that referenced
this pull request
Nov 13, 2024
Signed-off-by: Jose Luis Rivero <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
🎉 New feature
Summary
This simplifies the process of creating a config.yaml file by supporting the
gz fuel configure
CLI. This new CLI walks a user through the process of creating a config.yaml file that will live in~/.gz/fuel/
.The primary benefit is that it makes it easier to store and then use private access tokens.
Test it
Checklist
codecheck
passed (See contributing)Note to maintainers: Remember to use Squash-Merge and edit the commit message to match the pull request summary while retaining
Signed-off-by
messages.