Migrate curl_formadd from form API to mime API (deprecated in Ubuntu Noble) #415
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Jose Luis Rivero <[email protected]>
Fixed the memory problems in #416 |
nkoenig
reviewed
Apr 24, 2024
| @@ -314,8 +307,7 @@ RestResponse Rest::Request(HttpMethod _method, | |||
| } | |||
| else if (_method == HttpMethod::POST_FORM) | |||
| { | |||
| formpost = BuildFormPost(_form); | |||
| curl_easy_setopt(curl, CURLOPT_HTTPPOST, formpost); | |||
| AddFormPost(multipart, _form); | |||
There was a problem hiding this comment.
Should there be the following line here?
curl_easy_setopt(curl, CURLOPT_MIMEPOST, multipart);
There was a problem hiding this comment.
good catch! reviewing the deprecation instruction you are right.
Signed-off-by: Jose Luis Rivero <[email protected]>
nkoenig
approved these changes
Apr 29, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
🦟 Bug fix
Summary
The new curl 8.x series deprecate part of the CURL API that is being used in fuel-tools. I was totally new to the CURL APIs but there was a good documentation on how to migrate the old form API to the new MIME API in https://curl.se/libcurl/c/libcurl-tutorial.html (search by Converting from deprecated form api to mime api) so I went ahead and try to get the thing working.
I don't see any new test failure but probably we need someone with more knowledge of fuel to review that things are actually working.
I ran the ASAN analizer but found that we already have problems on the ASAN build (although Jenkins is not reporting them probably because gazebosim/gz-cmake#240).
Checklist
codecheckpassed (See contributing)Note to maintainers: Remember to use Squash-Merge and edit the commit message to match the pull request summary while retaining
Signed-off-bymessages.