Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix a test #419

Merged
merged 1 commit into from
May 1, 2024
Merged

Fix a test #419

merged 1 commit into from
May 1, 2024

Conversation

nkoenig
Copy link
Contributor

@nkoenig nkoenig commented Apr 29, 2024

🦟 Bug fix

Summary

This test shouldn't have the 1.0 in the URL. Not sure how this passed in a previous build.

Checklist

  • Signed all commits for DCO
  • Added tests
  • Updated documentation (as needed)
  • Updated migration guide (as needed)
  • Consider updating Python bindings (if the library has them)
  • codecheck passed (See contributing)
  • All tests passed (See test coverage)
  • While waiting for a review on your PR, please help review another open pull request to support the maintainers

Note to maintainers: Remember to use Squash-Merge and edit the commit message to match the pull request summary while retaining Signed-off-by messages.

Signed-off-by: Nate Koenig <[email protected]>
@github-actions github-actions bot added the 🌱 garden Ignition Garden label Apr 29, 2024
Copy link

codecov bot commented May 1, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 75.23%. Comparing base (2c84439) to head (38d0874).
Report is 4 commits behind head on gz-fuel-tools8.

Additional details and impacted files
@@                Coverage Diff                 @@
##           gz-fuel-tools8     #419      +/-   ##
==================================================
- Coverage           75.32%   75.23%   -0.10%     
==================================================
  Files                  20       20              
  Lines                2910     2923      +13     
==================================================
+ Hits                 2192     2199       +7     
- Misses                718      724       +6     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@azeey azeey merged commit 5acfbe1 into gz-fuel-tools8 May 1, 2024
11 of 12 checks passed
@azeey azeey deleted the nkoenig/fix_test branch May 1, 2024 21:45
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
🌱 garden Ignition Garden
Projects
Archived in project
Development

Successfully merging this pull request may close these issues.

2 participants