Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix tests pulling from wrong server #421

Merged
merged 1 commit into from
May 6, 2024

Conversation

Blast545
Copy link
Contributor

@Blast545 Blast545 commented May 6, 2024

🦟 Bug fix

Fixes Fuel_tools4 CI and Fuel_tools7 CI

Reference builds:
https://build.osrfoundation.org/job/gz_fuel_tools-ci-ign-fuel-tools4-focal-amd64/41/
https://build.osrfoundation.org/job/gz_fuel_tools-ci-ign-fuel-tools7-focal-amd64/48/

Summary

I don't think this has been reported, but Citadel and Fortress CI has been failing on Linux to run some tests requiring to download some models. The tests fail with timeouts, but the problem is that the server url is not configured properly, and so it's not capable of downloading anything.

I fixed this by using the same configuration as in more recent distributions. This will require a Forward Port to Fortress after it gets merged. FYI @Crola1702

Checklist

  • Signed all commits for DCO
  • Added tests
  • Updated documentation (as needed)
  • Updated migration guide (as needed)
  • Consider updating Python bindings (if the library has them)
  • codecheck passed (See contributing)
  • All tests passed (See test coverage)
  • While waiting for a review on your PR, please help review another open pull request to support the maintainers

Note to maintainers: Remember to use Squash-Merge and edit the commit message to match the pull request summary while retaining Signed-off-by messages.

@Blast545 Blast545 requested a review from nkoenig as a code owner May 6, 2024 14:16
@Blast545 Blast545 self-assigned this May 6, 2024
@github-actions github-actions bot added the 🏰 citadel Ignition Citadel label May 6, 2024
@Blast545 Blast545 requested a review from azeey May 6, 2024 14:16
@Blast545
Copy link
Contributor Author

Blast545 commented May 6, 2024

I installed citadel locally and tested this PR and it fixes the problem, Green CI so I will merge, thanks for the review Nate!

@Blast545 Blast545 merged commit 27beb60 into ign-fuel-tools4 May 6, 2024
10 checks passed
@Blast545 Blast545 deleted the blast545/fix_fuel_gazebo_tests branch May 6, 2024 16:32
Blast545 added a commit that referenced this pull request May 6, 2024
azeey pushed a commit that referenced this pull request May 6, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
🏰 citadel Ignition Citadel
Projects
Archived in project
Development

Successfully merging this pull request may close these issues.

2 participants