Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Require cmake 3.22.1 #436

Merged
merged 1 commit into from
Aug 23, 2024
Merged

Require cmake 3.22.1 #436

merged 1 commit into from
Aug 23, 2024

Conversation

scpeters
Copy link
Member

🎉 New feature

Part of gazebosim/gz-cmake#350.

Summary

This increases our minimum required cmake version to 3.22.1 since we are already requiring that in gz-cmake4.

Test it

Check that CI is successful.

Checklist

  • Signed all commits for DCO
  • Added tests
  • Added example and/or tutorial
  • Updated documentation (as needed)
  • Updated migration guide (as needed)
  • Consider updating Python bindings (if the library has them)
  • codecheck passed (See contributing)
  • All tests passed (See test coverage)
  • While waiting for a review on your PR, please help review another open pull request to support the maintainers

Note to maintainers: Remember to use Squash-Merge and edit the commit message to match the pull request summary while retaining Signed-off-by messages.

Part of gazebosim/gz-cmake#350.

Signed-off-by: Steve Peters <[email protected]>
@scpeters scpeters merged commit b0f37db into main Aug 23, 2024
10 checks passed
@scpeters scpeters deleted the scpeters/ionic_newer_cmake branch August 23, 2024 18:10
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
🏛️ ionic Gazebo Ionic
Projects
Archived in project
Development

Successfully merging this pull request may close these issues.

2 participants