Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Disable deprecation messages about onFoo connections #534

Merged
merged 2 commits into from
Apr 12, 2023

Conversation

azeey
Copy link
Contributor

@azeey azeey commented Apr 11, 2023

🦟 Bug fix

Summary

Alternative to #493. See https://github.com/gazebosim/gz-gui/pull/493/files#r982750363

Checklist

  • Signed all commits for DCO
  • Added tests
  • Updated documentation (as needed)
  • Updated migration guide (as needed)
  • Consider updating Python bindings (if the library has them)
  • codecheck passed (See contributing)
  • All tests passed (See test coverage)
  • While waiting for a review on your PR, please help review another open pull request to support the maintainers

Note to maintainers: Remember to use Squash-Merge and edit the commit message to match the pull request summary while retaining Signed-off-by messages.

Signed-off-by: Addisu Z. Taddese <addisu@openrobotics.org>
@azeey azeey requested a review from jennuine as a code owner April 11, 2023 20:05
@github-actions github-actions bot added the 🌱 garden Ignition Garden label Apr 11, 2023
@codecov
Copy link

codecov bot commented Apr 11, 2023

Codecov Report

Merging #534 (d67d86a) into gz-gui7 (bf42b84) will increase coverage by 0.06%.
The diff coverage is 91.66%.

❗ Current head d67d86a differs from pull request most recent head fee57e2. Consider uploading reports for the commit fee57e2 to get more accurate results

@@             Coverage Diff             @@
##           gz-gui7     #534      +/-   ##
===========================================
+ Coverage    69.13%   69.19%   +0.06%     
===========================================
  Files           44       44              
  Lines         4921     4938      +17     
===========================================
+ Hits          3402     3417      +15     
- Misses        1519     1521       +2     
Impacted Files Coverage Δ
src/plugins/world_stats/WorldStats.cc 94.11% <91.30%> (-0.89%) ⬇️
src/Application.cc 85.97% <100.00%> (+0.03%) ⬆️

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

Copy link
Contributor

@jennuine jennuine left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the fix!

@azeey azeey merged commit f81686a into gazebosim:gz-gui7 Apr 12, 2023
@azeey azeey deleted the alt_fix_onfoo branch April 12, 2023 17:03
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
🌱 garden Ignition Garden
Projects
Archived in project
Development

Successfully merging this pull request may close these issues.

3 participants