Enable header layering checks for bazel build (#646)

* Enable parse_headers and process_headers_in_dependencies checks for bazel build Signed-off-by: Shameek Ganguly <[email protected]> * Enable layering checks for gz-math/eigen3 Signed-off-by: Shameek Ganguly <[email protected]> --------- Signed-off-by: Shameek Ganguly <[email protected]>
gazebosim · Nov 15, 2024 · ebfb0bf · ebfb0bf
1 parent 44e3bba
commit ebfb0bf
Show file tree

Hide file tree

Showing 10 changed files with 29 additions and 1 deletion.
diff --git a/.bazelrc b/.bazelrc
@@ -10,3 +10,6 @@ build --strip=never
 build --strict_system_includes
 build --fission=dbg
 build --features=per_object_debug_info
+
+# Enable header processing, required for layering checks with parse_header.
+build --process_headers_in_dependencies
diff --git a/BUILD.bazel b/BUILD.bazel
@@ -5,7 +5,10 @@ load("@rules_license//rules:license.bzl", "license")
 package(
     default_applicable_licenses = [":license"],
     default_visibility = ["//visibility:public"],
-    features = ["layering_check"],
+    features = [
+        "layering_check",
+        "parse_headers",
+    ],
 )
 
 license(
@@ -592,6 +595,10 @@ cc_library(
     name = "MaterialType",
     hdrs = ["include/gz/math/MaterialType.hh"],
     includes = ["include"],
+    deps = [
+        ":Config",
+        ":Export",
+    ],
 )
 
 cc_library(
@@ -698,6 +705,9 @@ cc_library(
     hdrs = ["include/gz/math/MovingWindowFilter.hh"],
     includes = ["include"],
     deps = [
+        ":Config",
+        ":Export",
+        ":Vector3",
         "@gz-utils//:SuppressWarning",
     ],
 )
@@ -757,6 +767,9 @@ cc_library(
     name = "PiecewiseScalarField3",
     hdrs = ["include/gz/math/PiecewiseScalarField3.hh"],
     includes = ["include"],
+    deps = [
+        ":Region3",
+    ],
 )
 
 cc_test(

diff --git a/eigen3/BUILD.bazel b/eigen3/BUILD.bazel
@@ -2,6 +2,10 @@ load("@rules_license//rules:license.bzl", "license")
 
 package(
     default_applicable_licenses = ["//:license"],
+    features = [
+        "layering_check",
+        "parse_headers",
+    ],
 )
 
 license(

diff --git a/include/gz/math/detail/Box.hh b/include/gz/math/detail/Box.hh
@@ -17,6 +17,7 @@
 #ifndef GZ_MATH_DETAIL_BOX_HH_
 #define GZ_MATH_DETAIL_BOX_HH_
 
+#include "gz/math/Box.hh"
 #include "gz/math/Triangle3.hh"
 
 #include <optional>

diff --git a/include/gz/math/detail/Capsule.hh b/include/gz/math/detail/Capsule.hh
@@ -19,6 +19,7 @@
 
 #include <limits>
 #include <optional>
+#include <gz/math/Capsule.hh>
 #include <gz/math/Helpers.hh>
 #include <gz/math/Inertial.hh>
 

diff --git a/include/gz/math/detail/Cone.hh b/include/gz/math/detail/Cone.hh
@@ -20,6 +20,7 @@
 #define GZ_MATH_DETAIL_CONE_HH_
 
 #include <optional>
+#include "gz/math/Cone.hh"
 
 namespace gz::math
 {

diff --git a/include/gz/math/detail/Cylinder.hh b/include/gz/math/detail/Cylinder.hh
@@ -18,6 +18,7 @@
 #define GZ_MATH_DETAIL_CYLINDER_HH_
 
 #include <optional>
+#include "gz/math/Cylinder.hh"
 
 namespace gz::math
 {

diff --git a/include/gz/math/detail/Ellipsoid.hh b/include/gz/math/detail/Ellipsoid.hh
@@ -19,6 +19,7 @@
 
 #include <limits>
 #include <optional>
+#include "gz/math/Ellipsoid.hh"
 #include <gz/math/Helpers.hh>
 #include <gz/math/Inertial.hh>
 

diff --git a/src/KmeansPrivate.hh b/src/KmeansPrivate.hh
@@ -21,6 +21,7 @@
 #include <gz/math/Vector3.hh>
 #include <gz/math/Helpers.hh>
 #include <gz/math/config.hh>
+#include <gz/math/Kmeans.hh>
 
 namespace gz
 {

diff --git a/src/MaterialType.hh b/src/MaterialType.hh
@@ -20,6 +20,8 @@
 #include <array>
 #include <utility>
 
+#include "gz/math/Material.hh"
+
 using namespace gz;
 using namespace math;