Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Use HIDE_SYMBOLS_BY_DEFAULT #567

Closed
wants to merge 1 commit into from
Closed

Use HIDE_SYMBOLS_BY_DEFAULT #567

wants to merge 1 commit into from

Conversation

scpeters
Copy link
Member

@scpeters scpeters commented Nov 6, 2023

🎉 New feature

Part of testing gazebosim/gz-cmake#392

I expect this to require the changes from #566

Summary

Test it

Checklist

  • Signed all commits for DCO
  • Added tests
  • Added example and/or tutorial
  • Updated documentation (as needed)
  • Updated migration guide (as needed)
  • Consider updating Python bindings (if the library has them)
  • codecheck passed (See contributing)
  • All tests passed (See test coverage)
  • While waiting for a review on your PR, please help review another open pull request to support the maintainers

Note to maintainers: Remember to use Squash-Merge and edit the commit message to match the pull request summary while retaining Signed-off-by messages.

@scpeters
Use HIDE_SYMBOLS_BY_DEFAULT
75a19c7 
Part of testing gazebosim/gz-cmake#392

Signed-off-by: Steve Peters <[email protected]>

Signed-off-by: Steve Peters <[email protected]>
@scpeters scpeters requested a review from j-rivero November 6, 2023 21:39
@scpeters
Copy link
Member Author

scpeters commented Nov 6, 2023

I've merged this into #566

@scpeters scpeters closed this Nov 6, 2023
@scpeters scpeters deleted the scpeters/hide_symbols_by_default branch November 6, 2023 23:37
@scpeters scpeters mentioned this pull request Nov 6, 2023
Merged
8 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@j-rivero j-rivero Awaiting requested review from j-rivero

@adityapande-1995 adityapande-1995 Awaiting requested review from adityapande-1995 adityapande-1995 will be requested when the pull request is marked ready for review adityapande-1995 is a code owner

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
1 participant
@scpeters