Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[ign -> gz] CMake functions #263

Merged
merged 1 commit into from
Jun 17, 2022
Merged

[ign -> gz] CMake functions #263

merged 1 commit into from
Jun 17, 2022

Conversation

chapulina
Copy link
Contributor

@chapulina
[ign -> gz] CMake functions
a2ea55b 
Signed-off-by: Louise Poubel <[email protected]>
@chapulina chapulina added the ign to gz Renaming Ignition to Gazebo. label Jun 16, 2022
@chapulina chapulina requested a review from methylDragon June 16, 2022 20:39
@chapulina chapulina requested a review from caguero as a code owner June 16, 2022 20:39
@github-actions github-actions bot added the 🌱 garden Ignition Garden label Jun 16, 2022
@chapulina chapulina mentioned this pull request Jun 16, 2022
Closed
17 tasks
@codecov
Copy link

codecov bot commented Jun 16, 2022 •
edited
Loading

Codecov Report

Merging #263 (a2ea55b) into main (422a18f) will not change coverage.
The diff coverage is n/a.

@@           Coverage Diff           @@
##             main     #263   +/-   ##
=======================================
  Coverage   14.53%   14.53%           
=======================================
  Files         200      200           
  Lines       12505    12505           
=======================================
  Hits         1817     1817           
  Misses      10688    10688

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 422a18f...a2ea55b. Read the comment docs.

methylDragon
methylDragon approved these changes Jun 17, 2022
View reviewed changes
Copy link
Contributor

@methylDragon methylDragon left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Stack builds with this 👌

@chapulina chapulina merged commit e240db2 into main Jun 17, 2022
@chapulina chapulina deleted the chapulina/9/cmake_gz branch June 17, 2022 15:47
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@methylDragon methylDragon methylDragon approved these changes

@caguero caguero Awaiting requested review from caguero caguero is a code owner

Assignees
No one assigned
Labels
🌱 garden Ignition Garden ign to gz Renaming Ignition to Gazebo.
Projects
Core development
Archived in project
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@chapulina @methylDragon