Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Link to sdformat10 cmake target #314

Merged
merged 1 commit into from
Dec 10, 2021

Conversation

scpeters
Copy link
Member

🦟 Bug fix

Needed by gazebosim/sdformat#780

Summary

This links to the proper cmake target for sdformat, which is better than using the SDFormat_LIBRARIES variable. That variable may be removed in gazebosim/sdformat#780, so it's good to make this change now.

Checklist

  • Signed all commits for DCO
  • Added tests
  • Updated documentation (as needed)
  • Updated migration guide (as needed)
  • codecheck passed (See contributing)
  • All tests passed (See test coverage)
  • While waiting for a review on your PR, please help review another open pull request to support the maintainers

Note to maintainers: Remember to use Squash-Merge

This is better than the SDFormat_LIBRARIES variable.

Signed-off-by: Steve Peters <[email protected]>
@codecov
Copy link

codecov bot commented Dec 10, 2021

Codecov Report

Merging #314 (c4a2874) into ign-physics3 (fa93f17) will not change coverage.
The diff coverage is n/a.

❗ Current head c4a2874 differs from pull request most recent head 0a6fac3. Consider uploading reports for the commit 0a6fac3 to get more accurate results
Impacted file tree graph

@@              Coverage Diff              @@
##           ign-physics3     #314   +/-   ##
=============================================
  Coverage         74.66%   74.66%           
=============================================
  Files               117      117           
  Lines              4906     4906           
=============================================
  Hits               3663     3663           
  Misses             1243     1243           

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update fa93f17...0a6fac3. Read the comment docs.

@scpeters scpeters merged commit 09924c3 into gazebosim:ign-physics3 Dec 10, 2021
@scpeters scpeters deleted the sdf_cmake_target branch December 10, 2021 18:36
@osrf-triage
Copy link

This pull request has been mentioned on Gazebo Community. There might be relevant details there:

https://community.gazebosim.org/t/new-ignition-releases-2022-01-10/1228/1

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
🔮 dome Ignition Dome
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants