Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[ign -> gz] CMake functions #358

Merged
merged 1 commit into from
Jun 18, 2022
Merged

[ign -> gz] CMake functions #358

merged 1 commit into from
Jun 18, 2022

Conversation

chapulina
Copy link
Contributor

@chapulina chapulina commented Jun 16, 2022 •
edited
Loading

@chapulina chapulina added the ign to gz Renaming Ignition to Gazebo. label Jun 16, 2022
@chapulina chapulina requested a review from methylDragon June 16, 2022 21:18
@chapulina chapulina mentioned this pull request Jun 16, 2022
Closed
17 tasks
@chapulina chapulina added the needs upstream release Blocked by a release of an upstream library label Jun 16, 2022
@github-actions github-actions bot added the 🌱 garden Ignition Garden label Jun 16, 2022
@methylDragon
Copy link
Contributor

gz_add_benchmarks() is not tick-tocked yet from gz-cmake, so it causes the build to break

methylDragon
methylDragon requested changes Jun 17, 2022
View reviewed changes
Copy link
Contributor

@methylDragon methylDragon left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pending gz_add_benchmarks()

@chapulina chapulina mentioned this pull request Jun 17, 2022
Merged
@chapulina chapulina marked this pull request as ready for review June 17, 2022 20:26
@chapulina chapulina removed the needs upstream release Blocked by a release of an upstream library label Jun 17, 2022
@methylDragon
Copy link
Contributor

@osrf-jenkins run tests please!

@chapulina @methylDragon
[ign -> gz] CMake functions
65f4bf2 
Signed-off-by: Louise Poubel <[email protected]>
@methylDragon methylDragon force-pushed the chapulina/6/cmake_gz branch from a745896 to 65f4bf2 Compare June 18, 2022 03:29
@codecov
Copy link

codecov bot commented Jun 18, 2022 •
edited
Loading

Codecov Report

Merging #358 (65f4bf2) into main (ab627be) will not change coverage.
The diff coverage is n/a.

@@           Coverage Diff           @@
##             main     #358   +/-   ##
=======================================
  Coverage   75.46%   75.46%           
=======================================
  Files         128      128           
  Lines        5552     5552           
=======================================
  Hits         4190     4190           
  Misses       1362     1362

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update ab627be...65f4bf2. Read the comment docs.

@methylDragon methylDragon merged commit e51974d into main Jun 18, 2022
@methylDragon methylDragon deleted the chapulina/6/cmake_gz branch June 18, 2022 04:13
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@methylDragon methylDragon methylDragon approved these changes

@azeey azeey Awaiting requested review from azeey azeey is a code owner

@mxgrey mxgrey Awaiting requested review from mxgrey

@scpeters scpeters Awaiting requested review from scpeters scpeters is a code owner

Assignees
No one assigned
Labels
🌱 garden Ignition Garden ign to gz Renaming Ignition to Gazebo.
Projects
Core development
Archived in project
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@chapulina @methylDragon