Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

bullet-featherstone: Reset joint motor constraint's velocity target after each step #699

Merged
merged 1 commit into from
Nov 5, 2024

Conversation

iche033
Copy link
Contributor

@iche033 iche033 commented Oct 29, 2024

🦟 Bug fix

Fixes gazebosim/gz-sim#2654

Summary

Resets the joint velocity cmd after each step to be consistent with dart behavior.

Note: I also tried removing the joint motor constraint after each step but that didn't work (test fails) so opted to reset the joint velocity target to 0.

We have a test for this in joint_features but only for dart. This PR enables the test for bullet-featherstone as well. There is also a test in gz-sim in a branch (see instructions in gazebosim/gz-sim#2654). The test there should now pass with these changes.

Checklist

  • Signed all commits for DCO
  • Added tests
  • Updated documentation (as needed)
  • Updated migration guide (as needed)
  • Consider updating Python bindings (if the library has them)
  • codecheck passed (See contributing)
  • All tests passed (See test coverage)
  • While waiting for a review on your PR, please help review another open pull request to support the maintainers

Note to maintainers: Remember to use Squash-Merge and edit the commit message to match the pull request summary while retaining Signed-off-by messages.

@iche033 iche033 added the Bullet Bullet engine label Oct 29, 2024
@github-actions github-actions bot added the 🏛️ ionic Gazebo Ionic label Oct 29, 2024
@iche033 iche033 merged commit 0fb5974 into gz-physics8 Nov 5, 2024
11 checks passed
@iche033 iche033 deleted the reset_joint_vel_bullet branch November 5, 2024 18:37
iche033 added a commit that referenced this pull request Nov 5, 2024
iche033 added a commit that referenced this pull request Nov 5, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Bullet Bullet engine 🏛️ ionic Gazebo Ionic
Projects
Archived in project
Development

Successfully merging this pull request may close these issues.

bullet-featherstone: JointVelocityCmd components remain in effect even after being deleted
2 participants