bullet-featherstone: Reset joint motor constraint's velocity target after each step #699
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
🦟 Bug fix
Fixes gazebosim/gz-sim#2654
Summary
Resets the joint velocity cmd after each step to be consistent with dart behavior.
Note: I also tried removing the joint motor constraint after each step but that didn't work (test fails) so opted to reset the joint velocity target to 0.
We have a test for this in
joint_features
but only for dart. This PR enables the test for bullet-featherstone as well. There is also a test in gz-sim in a branch (see instructions in gazebosim/gz-sim#2654). The test there should now pass with these changes.Checklist
codecheck
passed (See contributing)Note to maintainers: Remember to use Squash-Merge and edit the commit message to match the pull request summary while retaining
Signed-off-by
messages.