Skip to content

Commit

Permalink
Remove todo in gpu ray test (#949)
Browse files Browse the repository at this point in the history
Remove code as mentioned in the todo note now that the OgreHeightmap::Destroy function is available. The test should not crash.

Signed-off-by: Ian Chen <[email protected]>
  • Loading branch information
iche033 authored Jan 2, 2024
1 parent 93c2785 commit 5cad5c0
Showing 1 changed file with 0 additions and 8 deletions.
8 changes: 0 additions & 8 deletions test/integration/gpu_rays.cc
Original file line number Diff line number Diff line change
Expand Up @@ -1024,14 +1024,6 @@ TEST_F(GpuRaysTest, GZ_UTILS_TEST_DISABLED_ON_WIN32(Heightmap))
delete [] scan;
scan = nullptr;

// \todo(iche033) Implement Ogre2Heightmap::Destroy function in gz-rendering8
// this should not be needed once Ogre2Heightmap::Destroy is implemented.
if (engine->Name() == "ogre2")
{
vis->Destroy();
heightmap.reset();
}

// Clean up
engine->DestroyScene(scene);
}

0 comments on commit 5cad5c0

Please sign in to comment.