Disable Unit test that have segfaults on Mac (rendering3) #1023
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Crola1702 <[email protected]>
Signed-off-by: Crola1702 <[email protected]>
Signed-off-by: Crola1702 <[email protected]>
Signed-off-by: Crola1702 <[email protected]>
Signed-off-by: Crola1702 <[email protected]>
Signed-off-by: Crola1702 <[email protected]>
Crola1702
changed the title
Blast545
reviewed
Jul 26, 2024
Comment on lines
+13
to
+21
| if (APPLE) | ||
| list(REMOVE_ITEM tests camera.cc) | ||
| list(REMOVE_ITEM tests depth_camera.cc) | ||
| list(REMOVE_ITEM tests render_pass.cc) | ||
| list(REMOVE_ITEM tests shadows.cc) | ||
| list(REMOVE_ITEM tests scene.cc) | ||
| list(REMOVE_ITEM tests thermal_camera.cc) | ||
| endif() | ||
|
|
There was a problem hiding this comment.
Is this needed with the other ifdef macros already in place?
There was a problem hiding this comment.
These disable Integration tests. ifdef disable unit tests.
iche033
approved these changes
Jul 26, 2024
Blast545
approved these changes
Jul 29, 2024
I changed it to |
Crola1702
added a commit
that referenced
this pull request
Jul 30, 2024
* Remove camera.cc from integration tests Signed-off-by: Crola1702 <[email protected]> * Remove failing integration tests Signed-off-by: Crola1702 <[email protected]> * Disable ArrowVisual Test Signed-off-by: Crola1702 <[email protected]> * Disable Unit test that have segfaults on Mac Signed-off-by: Crola1702 <[email protected]> * Disable other tests Signed-off-by: Crola1702 <[email protected]> * Disable all tests that have segfaults in MacOs Signed-off-by: Crola1702 <[email protected]> --------- Signed-off-by: Crola1702 <[email protected]>
8 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
🦟 Bug fix
Disable tests from #847
Summary
This PR disables all tests that have segfaults in MacOS
Checklist
codecheckpassed (See contributing)Note to maintainers: Remember to use Squash-Merge and edit the commit message to match the pull request summary while retaining
Signed-off-bymessages.