Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Unload rendering plugin also on Windows #1074

Merged
merged 1 commit into from
Oct 9, 2024

Conversation

traversaro
Copy link
Contributor

@traversaro traversaro commented Oct 3, 2024

🦟 Bug fix

I am trying to run the Windows test suite on windows with conda-forge dependencies, and the only failures are:

The following tests FAILED:
         25 - INTEGRATION_gpu_rays_ogre2_gl3plus (Failed)
         35 - INTEGRATION_mesh_ogre_gl3plus (Failed)
         65 - INTEGRATION_thermal_camera_ogre2_gl3plus (Failed)
            - RenderingIface_TEST_ogre2_gl3plus (Failed)

The RenderingIface_TEST_ogre2_gl3plus is fixed by removing this old workaround. I opened this to understand if this breaks something.

Summary

Checklist

  • Signed all commits for DCO
  • Added tests
  • Updated documentation (as needed)
  • Updated migration guide (as needed)
  • Consider updating Python bindings (if the library has them)
  • codecheck passed (See contributing)
  • All tests passed (See test coverage)
  • While waiting for a review on your PR, please help review another open pull request to support the maintainers

@traversaro traversaro requested a review from iche033 as a code owner October 3, 2024 15:27
@traversaro traversaro changed the base branch from main to gz-rendering9 October 3, 2024 15:27
@traversaro
Copy link
Contributor Author

If this works, probably we can close #45 .

@iche033
Copy link
Contributor

iche033 commented Oct 3, 2024

looks like the win tests are failing in the same way as before?

@traversaro
Copy link
Contributor Author

Ah, by the way I missed #1049, were you referring to that or Jenkins? It seems that there indeed there the test can't find the engine.

@iche033
Copy link
Contributor

iche033 commented Oct 4, 2024

ah I was looking at jenkins, didn't notice that the windows github actions was not running.

@iche033 iche033 merged commit a7a7247 into gazebosim:gz-rendering9 Oct 9, 2024
10 of 11 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Archived in project
Development

Successfully merging this pull request may close these issues.

2 participants