Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Check valid camera near far clip distances #1082

Merged
merged 1 commit into from
Nov 1, 2024
Merged

Conversation

iche033
Copy link
Contributor

@iche033 iche033 commented Oct 31, 2024

🦟 Bug fix

Fixes gazebosim/gz-sim#2615

Summary

Added checks for valid camera clip distances to prevent ogre from throwing an exception

Checklist

  • Signed all commits for DCO
  • Added tests
  • Updated documentation (as needed)
  • Updated migration guide (as needed)
  • Consider updating Python bindings (if the library has them)
  • codecheck passed (See contributing)
  • All tests passed (See test coverage)
  • While waiting for a review on your PR, please help review another open pull request to support the maintainers

Note to maintainers: Remember to use Squash-Merge and edit the commit message to match the pull request summary while retaining Signed-off-by messages.

@github-actions github-actions bot added the 🏛️ ionic Gazebo Ionic label Oct 31, 2024
@iche033 iche033 merged commit 1f4def6 into gz-rendering9 Nov 1, 2024
11 of 12 checks passed
@iche033 iche033 deleted the clip_dist_check branch November 1, 2024 00:00
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
🏛️ ionic Gazebo Ionic
Projects
Archived in project
Development

Successfully merging this pull request may close these issues.

Crash after loading an sdf containing an invalid near clip distance parameter
2 participants