Do not create wirebox with empty AABB (ogre) #1083
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
🦟 Bug fix
Fixes #1000
Summary
Prevent creating a wirebox with empty AABB in ogre.
A
gz::math::AxisAlignedBox
initializes the bounds toMAX_D
andLOW_D
which results in aninf
AABB in ogre as it uses floats for AABB instead of doubles. This then leads to a crash when ogre tries to render the scene.See #1000 for a description on how to reproduce the crash with gz-sim. You can launch gazebo with ogre render engine by running:
Expand the
sun
item in theEntity Tree
and click onsunVisual
to see the crash.The changes in this PR only prevent the crash - it does not actually display the wirebox for the light visual, which is the same as the original behavior.
Checklist
codecheck
passed (See contributing)Note to maintainers: Remember to use Squash-Merge and edit the commit message to match the pull request summary while retaining
Signed-off-by
messages.