Fail test if no scene can be created (gz-rendering6) #1090
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Replace current print by a FAIL in Gtest to make the test that can not create an scene to fail. This should help to avoid false positives in testing. Signed-off-by: Jose Luis Rivero <[email protected]>
ahcorde
approved these changes
Dec 3, 2024
iche033
reviewed
Dec 3, 2024
Signed-off-by: Jose Luis Rivero <[email protected]>
Ouch sorry I did not want to include them in this PR but create another one for them. Removed in 5254dd4 |
iche033
approved these changes
Dec 4, 2024
Signed-off-by: Jose Luis Rivero <[email protected]>
|
@azeey friendly ping to merge this as agreed on the last PMC meeting, thanks! |
|
removed Merging. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
🦟 Bug fix
Summary
Replace current print by a FAIL in Gtest to make the test that can not create an scene to fail. This should help to avoid false positives in testing.
Note that is going to make the current build of ign-rendering6 to fail many tests.
Checklist
codecheckpassed (See contributing)Note to maintainers: Remember to use Squash-Merge and edit the commit message to match the pull request summary while retaining
Signed-off-bymessages.