-
Notifications
You must be signed in to change notification settings - Fork 52
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add LookAt function to GizmoVisual class #882
Conversation
Signed-off-by: Ian Chen <[email protected]>
Signed-off-by: Ian Chen <[email protected]>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM, just a minor comment
Signed-off-by: Ian Chen <[email protected]>
Codecov Report
@@ Coverage Diff @@
## main #882 +/- ##
==========================================
+ Coverage 75.12% 75.26% +0.14%
==========================================
Files 176 176
Lines 16858 16853 -5
==========================================
+ Hits 12664 12685 +21
+ Misses 4194 4168 -26
|
Can we merge this after Harmonic? |
yes, no hurry |
🎉 New feature
Summary
The LookAt function updates the rotation visuals in a GizmoVisual so that they always face the specified position. This is used by TransformController so that the rotation visuals (handles) are always positioned in front of the attached object w.r.t the camera so that they are easy to click on by the mouse.
Checklist
codecheck
passed (See contributing)Note to maintainers: Remember to use Squash-Merge and edit the commit message to match the pull request summary while retaining
Signed-off-by
messages.