Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add LookAt function to GizmoVisual class #882

Merged
merged 4 commits into from
Oct 6, 2023
Merged

Add LookAt function to GizmoVisual class #882

merged 4 commits into from
Oct 6, 2023

Conversation

iche033
Copy link
Contributor

@iche033 iche033 commented Aug 16, 2023

🎉 New feature

Summary

The LookAt function updates the rotation visuals in a GizmoVisual so that they always face the specified position. This is used by TransformController so that the rotation visuals (handles) are always positioned in front of the attached object w.r.t the camera so that they are easy to click on by the mouse.

Checklist

  • Signed all commits for DCO
  • Added tests
  • Added example and/or tutorial
  • Updated documentation (as needed)
  • Updated migration guide (as needed)
  • Consider updating Python bindings (if the library has them)
  • codecheck passed (See contributing)
  • All tests passed (See test coverage)
  • While waiting for a review on your PR, please help review another open pull request to support the maintainers

Note to maintainers: Remember to use Squash-Merge and edit the commit message to match the pull request summary while retaining Signed-off-by messages.

@github-actions github-actions bot added the 🎵 harmonic Gazebo Harmonic label Aug 16, 2023
Signed-off-by: Ian Chen <[email protected]>
Copy link
Contributor

@ahcorde ahcorde left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, just a minor comment

include/gz/rendering/GizmoVisual.hh Outdated Show resolved Hide resolved
Signed-off-by: Ian Chen <[email protected]>
@codecov
Copy link

codecov bot commented Aug 16, 2023

Codecov Report

Merging #882 (14a457c) into main (71bde82) will increase coverage by 0.14%.
The diff coverage is 95.45%.

❗ Current head 14a457c differs from pull request most recent head f137e5b. Consider uploading reports for the commit f137e5b to get more accurate results

@@            Coverage Diff             @@
##             main     #882      +/-   ##
==========================================
+ Coverage   75.12%   75.26%   +0.14%     
==========================================
  Files         176      176              
  Lines       16858    16853       -5     
==========================================
+ Hits        12664    12685      +21     
+ Misses       4194     4168      -26     
Files Coverage Δ
include/gz/rendering/base/BaseGizmoVisual.hh 88.15% <100.00%> (+0.62%) ⬆️
src/TransformController.cc 63.45% <0.00%> (+5.04%) ⬆️

@azeey
Copy link
Contributor

azeey commented Aug 16, 2023

Can we merge this after Harmonic?

@iche033
Copy link
Contributor Author

iche033 commented Aug 16, 2023

Can we merge this after Harmonic?

yes, no hurry

@iche033 iche033 removed the 🎵 harmonic Gazebo Harmonic label Oct 6, 2023
@iche033 iche033 merged commit 30ec9d4 into main Oct 6, 2023
6 checks passed
@iche033 iche033 deleted the gizmo_lookat branch October 6, 2023 18:49
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants