Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

DO NOT MERGE: CI Testing #897 #899

Closed
wants to merge 4 commits into from

Conversation

mjcarroll
Copy link
Contributor

@github-actions github-actions bot added the 🎵 harmonic Gazebo Harmonic label Sep 5, 2023
@codecov
Copy link

codecov bot commented Sep 5, 2023

Codecov Report

Merging #899 (d96ab59) into gz-rendering8 (98c5978) will decrease coverage by 0.04%.
The diff coverage is 0.00%.

❗ Current head d96ab59 differs from pull request most recent head 62a53ac. Consider uploading reports for the commit 62a53ac to get more accurate results

@@                Coverage Diff                @@
##           gz-rendering8     #899      +/-   ##
=================================================
- Coverage          75.21%   75.18%   -0.04%     
=================================================
  Files                176      177       +1     
  Lines              16839    16846       +7     
=================================================
  Hits               12665    12665              
- Misses              4174     4181       +7     
Files Changed Coverage Δ
include/gz/rendering/base/BaseNativeWindow.hh 0.00% <ø> (ø)
ogre2/src/Ogre2GlobalIlluminationCiVct.cc 0.00% <0.00%> (ø)
ogre2/src/Ogre2RenderEngine.cc 68.18% <ø> (ø)
src/GlobalIlluminationBase.cc 0.00% <0.00%> (ø)
src/GlobalIlluminationCiVct.cc 0.00% <0.00%> (ø)
src/GlobalIlluminationVct.cc 0.00% <0.00%> (ø)
src/NativeWindow.cc 0.00% <0.00%> (ø)
src/base/BaseNativeWindow.cc 0.00% <0.00%> (ø)

@mjcarroll
Copy link
Contributor Author

@osrf-jenkins retest this please

@peci1
Copy link
Contributor

peci1 commented Sep 6, 2023

The build got stuck somehow... :(

@mjcarroll
Copy link
Contributor Author

@mjcarroll
Copy link
Contributor Author

Looks like it still didn't find OGRE2 from vcpkg. I have to get my Windows laptop out for other things today, I will check this on there.

@mjcarroll mjcarroll closed this Sep 14, 2023
@mjcarroll mjcarroll deleted the ci_matching_branch/fix_msvc branch September 14, 2023 19:13
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
🎵 harmonic Gazebo Harmonic
Projects
Archived in project
Development

Successfully merging this pull request may close these issues.

3 participants