Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[backport fortress] Calculate camera intrinsics : Refactor #905

Merged
merged 4 commits into from
Sep 22, 2023

Conversation

ahcorde
Copy link
Contributor

@ahcorde ahcorde commented Sep 13, 2023

🎉 New feature

Summary

[backport fortress] Calculate camera intrinsics : Refactor

Required in this PR gazebosim/gz-sensors#383

Checklist

  • Signed all commits for DCO
  • Added tests
  • Added example and/or tutorial
  • Updated documentation (as needed)
  • Updated migration guide (as needed)
  • Consider updating Python bindings (if the library has them)
  • codecheck passed (See contributing)
  • All tests passed (See test coverage)
  • While waiting for a review on your PR, please help review another open pull request to support the maintainers

Note to maintainers: Remember to use Squash-Merge and edit the commit message to match the pull request summary while retaining Signed-off-by messages.

* Added free function to get camera intrinsics
Signed-off-by: Aditya <[email protected]>
Signed-off-by: Alejandro Hernández Cordero <[email protected]>
Signed-off-by: Alejandro Hernández Cordero <[email protected]>
@ahcorde
Copy link
Contributor Author

ahcorde commented Sep 13, 2023

@osrf-jenkins run tests please!

@ahcorde ahcorde enabled auto-merge (squash) September 13, 2023 21:41
@ahcorde
Copy link
Contributor Author

ahcorde commented Sep 19, 2023

@iche033 I can't see where is the error on Windows, any thoughts? or we can merge this PR ?

@iche033 iche033 disabled auto-merge September 22, 2023 17:52
@iche033
Copy link
Contributor

iche033 commented Sep 22, 2023

yes merging

@iche033 iche033 merged commit b6f5d22 into ign-rendering6 Sep 22, 2023
@iche033 iche033 deleted the ahcorde/6/bp/700 branch September 22, 2023 17:53
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
🏯 fortress Ignition Fortress
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants