-
Notifications
You must be signed in to change notification settings - Fork 52
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Include the CGL header on macOS #911
Conversation
Signed-off-by: Michael Carroll <[email protected]>
looks good, will wait for CI |
thanks for the quick fix! |
Codecov Report
@@ Coverage Diff @@
## gz-rendering8 #911 +/- ##
==============================================
Coverage 75.18% 75.18%
==============================================
Files 177 177
Lines 16846 16846
==============================================
Hits 12665 12665
Misses 4181 4181
|
CI failure seems like a problem with the machine? https://build.osrfoundation.org/job/gz_rendering-ci-pr_any-jammy-amd64/49/
|
Or it could actually be a wrongly initialized GL context... |
I reran the Jammy job and it passed (https://build.osrfoundation.org/job/gz_rendering-ci-pr_any-jammy-amd64/51/), so I'd say this is okay to merge. |
Yeah, this should not have altered any jammy specific code paths, so maybe just a flake? |
Fix break from #897