Minor fix to checking projector default visibility flags #920
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
🦟 Bug fix
Summary
Fixed check to see if projector is using default or custom visibility flags. If it's using the default flags, we can skip all the extra computation added for visibility toggling.
The check is not quite correct (so it's currently not skipping the extra computations). The default visibility flags (from SDF) is
0xFFFFFFFF
but the code is checking againstGZ_VISIBILITY_ALL
which is0x0FFFFFFF
. So updated check to make sure the visibility flags contain all ofGZ_VISIBILITY_ALL
bits instead of exact equality comparison.This is more of a performance improvement and does not change projector behavior.
Checklist
codecheck
passed (See contributing)Note to maintainers: Remember to use Squash-Merge and edit the commit message to match the pull request summary while retaining
Signed-off-by
messages.