Merge 7 -> 8 #951
Merged
Merge 7 -> 8 #951
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
* Use metal as default on apple, fix compile warning, remove optix * Add defaultGraphicsAPI utility function --------- Signed-off-by: Ian Chen <[email protected]>
This was broken by gazebosim/gz-cmake#399, since we dropped the gazebo-specific flag, we can use native CMake mechanism for marking this library position-independent. Signed-off-by: Michael Carroll <[email protected]>
mjcarroll
approved these changes
Jan 4, 2024
Codecov ReportAttention:
Additional details and impacted files@@ Coverage Diff @@
## gz-rendering8 #951 +/- ##
=================================================
- Coverage 75.54% 75.54% -0.01%
=================================================
Files 177 177
Lines 16887 16889 +2
=================================================
Hits 12758 12758
- Misses 4129 4131 +2 ☔ View full report in Codecov by Sentry. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
➡️ Forward port
Port gz-rendering7 to gz-rendering8
Branch comparison: gz-rendering8...gz-rendering7
Note to maintainers: Remember to Merge with commit (not squash-merge or rebase)