Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

ign -> gz Upstream Macro Migration : gz-sensors #232

Merged
merged 6 commits into from
Jun 18, 2022
Merged

ign -> gz Upstream Macro Migration : gz-sensors #232

merged 6 commits into from
Jun 18, 2022

Conversation

methylDragon
Copy link
Contributor

@methylDragon methylDragon requested a review from iche033 as a code owner June 6, 2022 23:10
@methylDragon methylDragon mentioned this pull request Jun 6, 2022
Closed
@github-actions github-actions bot added the 🌱 garden Ignition Garden label Jun 6, 2022
@chapulina chapulina added the ign to gz Renaming Ignition to Gazebo. label Jun 6, 2022
@chapulina chapulina self-requested a review June 6, 2022 23:53
@chapulina chapulina added the needs upstream release Blocked by a release of an upstream library label Jun 7, 2022
chapulina
chapulina approved these changes Jun 7, 2022
View reviewed changes
Copy link
Contributor

@chapulina chapulina left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM with 🟢 CI!

chapulina
chapulina approved these changes Jun 9, 2022
View reviewed changes
Copy link
Contributor

@chapulina chapulina left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice, the gz:type tick-tock looks good too 👍🏽

@methylDragon
Migrate minor sdf test
b7b482e 
Signed-off-by: methylDragon <[email protected]>
@codecov
Copy link

codecov bot commented Jun 18, 2022 •
edited
Loading

Codecov Report

Merging #232 (b7b482e) into main (eb58297) will decrease coverage by 0.05%.
The diff coverage is 62.16%.

@@            Coverage Diff             @@
##             main     #232      +/-   ##
==========================================
- Coverage   68.73%   68.68%   -0.06%     
==========================================
  Files          34       34              
  Lines        3419     3423       +4     
==========================================
+ Hits         2350     2351       +1     
- Misses       1069     1072       +3
Impacted Files Coverage Δ
include/gz/sensors/ForceTorqueSensor.hh 100.00% <ø> (ø)
include/gz/sensors/Manager.hh 81.81% <ø> (ø)
include/gz/sensors/NavSatSensor.hh 100.00% <ø> (ø)
include/gz/sensors/SensorFactory.hh 58.33% <ø> (ø)
src/AirPressureSensor.cc 86.30% <ø> (ø)
src/AltimeterSensor.cc 88.50% <ø> (ø)
src/Distortion.cc 0.00% <0.00%> (ø)
src/ForceTorqueSensor.cc 80.90% <ø> (ø)
src/GpuLidarSensor.cc 89.26% <ø> (ø)
src/ImageDistortion.cc 0.00% <0.00%> (ø)
... and 17 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update eb58297...b7b482e. Read the comment docs.

@methylDragon methylDragon merged commit b28c237 into main Jun 18, 2022
@methylDragon methylDragon deleted the macro_migration branch June 18, 2022 02:52
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@chapulina chapulina chapulina approved these changes

@iche033 iche033 Awaiting requested review from iche033 iche033 is a code owner

Assignees
No one assigned
Labels
🌱 garden Ignition Garden ign to gz Renaming Ignition to Gazebo. needs upstream release Blocked by a release of an upstream library
Projects
Core development
Archived in project
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@methylDragon @chapulina