Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[ign -> gz] CMake functions #237

Merged
merged 1 commit into from
Jun 17, 2022
Merged

[ign -> gz] CMake functions #237

merged 1 commit into from
Jun 17, 2022

Conversation

chapulina
Copy link
Contributor

@chapulina
[ign -> gz] CMake functions
613de94 
Signed-off-by: Louise Poubel <[email protected]>
@chapulina chapulina added the ign to gz Renaming Ignition to Gazebo. label Jun 16, 2022
@chapulina chapulina requested a review from methylDragon June 16, 2022 21:14
@chapulina chapulina requested a review from iche033 as a code owner June 16, 2022 21:14
@chapulina chapulina mentioned this pull request Jun 16, 2022
Closed
17 tasks
@github-actions github-actions bot added the 🌱 garden Ignition Garden label Jun 16, 2022
@codecov
Copy link

codecov bot commented Jun 16, 2022 •
edited
Loading

Codecov Report

Merging #237 (d12caf6) into main (1dccfc4) will not change coverage.
The diff coverage is n/a.

❗ Current head d12caf6 differs from pull request most recent head 613de94. Consider uploading reports for the commit 613de94 to get more accurate results

@@           Coverage Diff           @@
##             main     #237   +/-   ##
=======================================
  Coverage   68.73%   68.73%           
=======================================
  Files          34       34           
  Lines        3419     3419           
=======================================
  Hits         2350     2350           
  Misses       1069     1069

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 1dccfc4...613de94. Read the comment docs.

methylDragon
methylDragon approved these changes Jun 17, 2022
View reviewed changes
Copy link
Contributor

@methylDragon methylDragon left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Stack builds with this 👌

@methylDragon
Copy link
Contributor

methylDragon commented Jun 17, 2022 •
edited
Loading

Errors in CI aren't new

@chapulina chapulina merged commit eb58297 into main Jun 17, 2022
@chapulina chapulina deleted the chapulina/7/cmake_gz branch June 17, 2022 15:50
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@methylDragon methylDragon methylDragon approved these changes

@iche033 iche033 Awaiting requested review from iche033 iche033 is a code owner

Assignees
No one assigned
Labels
🌱 garden Ignition Garden ign to gz Renaming Ignition to Gazebo.
Projects
Core development
Archived in project
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@chapulina @methylDragon