Use GZ_ visibilty macro instead of custom _EXPORTS_API #400
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Jose Luis Rivero <[email protected]>
Codecov Report
@@ Coverage Diff @@
## main #400 +/- ##
=======================================
Coverage 72.36% 72.36%
=======================================
Files 37 37
Lines 5055 5055
=======================================
Hits 3658 3658
Misses 1397 1397 |
|
windows build is currently broken, likely caused by gazebosim/gz-common#548 |
Signed-off-by: Jose Luis Rivero <[email protected]>
|
@osrf-jenkins run tests please |
azeey
approved these changes
Nov 13, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Part of the works to enable visibility hidden by default gazebosim/gz-cmake#392. Part of gazebosim/gz-cmake#166
The PR replaces a custom visibility method by the macro provided by gz-cmake.