Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Set rendering sensor pose #439

Merged
merged 2 commits into from
Jun 6, 2024
Merged

Set rendering sensor pose #439

merged 2 commits into from
Jun 6, 2024

Conversation

iche033
Copy link
Contributor

@iche033 iche033 commented May 31, 2024

🦟 Bug fix

Related PR: gazebosim/gz-sim#2425

Summary

When most of the rendering sensors are created, I realized that we do not actually set the pose of the internal rendering sensor objects anywhere in gz-sensors. Instead we currently rely on gz-sim to update these poses on every iteration. This PR now sets the sensor pose on creation. It removes pose updates in relevant Update functions if any. Additionally for camera based sensors, the final pose of the camera sensor is the combined result of both //sensor/pose and //sensor/camera/pose. Update: No longer setting final pose to take into account //sensor/camera/pose, see gazebosim/gz-sim#2433 (comment) - planning to deprecate / remove this tag.

Checklist

  • Signed all commits for DCO
  • Added tests
  • Updated documentation (as needed)
  • Updated migration guide (as needed)
  • Consider updating Python bindings (if the library has them)
  • codecheck passed (See contributing)
  • All tests passed (See test coverage)
  • While waiting for a review on your PR, please help review another open pull request to support the maintainers

Note to maintainers: Remember to use Squash-Merge and edit the commit message to match the pull request summary while retaining Signed-off-by messages.

Signed-off-by: Ian Chen <[email protected]>
Signed-off-by: Ian Chen <[email protected]>
@iche033 iche033 merged commit 4d2ae18 into gz-sensors8 Jun 6, 2024
8 checks passed
@iche033 iche033 deleted the rendering_sensor_pose branch June 6, 2024 07:17
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
🎵 harmonic Gazebo Harmonic
Projects
Archived in project
Development

Successfully merging this pull request may close these issues.

2 participants