Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
🦟 Bug fix
Related PR: gazebosim/gz-sim#2425
Summary
When most of the rendering sensors are created, I realized that we do not actually set the pose of the internal rendering sensor objects anywhere in gz-sensors. Instead we currently rely on gz-sim to update these poses on every iteration. This PR now sets the sensor pose on creation. It removes pose updates in relevant
Update
functions if any.Additionally for camera based sensors, the final pose of the camera sensor is the combined result of bothUpdate: No longer setting final pose to take into account//sensor/pose
and//sensor/camera/pose
.//sensor/camera/pose
, see gazebosim/gz-sim#2433 (comment) - planning to deprecate / remove this tag.Checklist
codecheck
passed (See contributing)Note to maintainers: Remember to use Squash-Merge and edit the commit message to match the pull request summary while retaining
Signed-off-by
messages.