Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Added Trigger to Depth camera #484

Merged
merged 2 commits into from
Nov 21, 2024

Conversation

ahcorde
Copy link
Contributor

@ahcorde ahcorde commented Nov 20, 2024

🎉 New feature

Summary

Added Trigger to Depth camera

Test it

Checklist

  • Signed all commits for DCO
  • Added tests
  • Added example and/or tutorial
  • Updated documentation (as needed)
  • Updated migration guide (as needed)
  • Consider updating Python bindings (if the library has them)
  • codecheck passed (See contributing)
  • All tests passed (See test coverage)
  • While waiting for a review on your PR, please help review another open pull request to support the maintainers

Note to maintainers: Remember to use Squash-Merge and edit the commit message to match the pull request summary while retaining Signed-off-by messages.

Signed-off-by: Alejandro Hernández Cordero <[email protected]>
@ahcorde ahcorde self-assigned this Nov 20, 2024
@ahcorde ahcorde requested a review from iche033 as a code owner November 20, 2024 20:55
@github-actions github-actions bot added the 🏯 fortress Ignition Fortress label Nov 20, 2024
@iche033
Copy link
Contributor

iche033 commented Nov 20, 2024

Note that #431 added the trigger functionality for all sensors in Harmonic. We could backport #431 but I think there'll be quite a bit of conflicts. Changes look good here if we just want the trigger functionality for depth cameras.

@ahcorde ahcorde merged commit 51bf62d into ign-sensors6 Nov 21, 2024
10 checks passed
@ahcorde ahcorde deleted the ahcorde/fortress/depth_camera_trigger branch November 21, 2024 11:28
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
🏯 fortress Ignition Fortress
Projects
Status: Done
Development

Successfully merging this pull request may close these issues.

2 participants