Skip to content

Commit

Permalink
Merge pull request #2191 from azeey/3_to_6
Browse files Browse the repository at this point in the history
Merge ign-gazebo3 ➡️  ign-gazebo6
  • Loading branch information
azeey authored Oct 5, 2023
2 parents 326cef2 + 8511623 commit eaad78f
Show file tree
Hide file tree
Showing 2 changed files with 3 additions and 3 deletions.
4 changes: 2 additions & 2 deletions src/SdfGenerator_TEST.cc
Original file line number Diff line number Diff line change
Expand Up @@ -644,13 +644,13 @@ TEST_F(ElementUpdateFixture, WorldWithModelsIncludedNotExpanded)
TEST_F(ElementUpdateFixture, WorldWithModelsIncludedWithInvalidUris)
{
const std::string goodUri =
"https://fuel.gazebosim.org/1.0/OpenRobotics/models/Backpack/2";
"https://fuel.gazebosim.org/1.0/OpenRobotics/models/Backpack/3";

// These are URIs that are potentially problematic.
const std::vector<std::string> fuelUris = {
// Thes following two URIs are valid, but have a trailing '/'
"https://fuel.gazebosim.org/1.0/OpenRobotics/models/Backpack/",
"https://fuel.gazebosim.org/1.0/OpenRobotics/models/Backpack/2/",
"https://fuel.gazebosim.org/1.0/OpenRobotics/models/Backpack/3/",
// Thes following two URIs are invalid, and will not be saved
"https://fuel.gazebosim.org/1.0/OpenRobotics/models/Backpack/"
"notInt",
Expand Down
2 changes: 1 addition & 1 deletion test/integration/save_world.cc
Original file line number Diff line number Diff line change
Expand Up @@ -419,7 +419,7 @@ TEST_F(SdfGeneratorFixture, ModelWithNestedIncludes)
ASSERT_NE(nullptr, uri);
ASSERT_NE(nullptr, uri->GetText());
EXPECT_EQ(
"https://fuel.ignitionrobotics.org/1.0/OpenRobotics/models/Coke Can/2",
"https://fuel.ignitionrobotics.org/1.0/OpenRobotics/models/Coke Can/3",
std::string(uri->GetText()));

name = include->FirstChildElement("name");
Expand Down

0 comments on commit eaad78f

Please sign in to comment.