Skip to content

Commit

Permalink
Remove GZ_PHYSICS_ENGINE_INSTALL_DIR deprecation warnings (#2106)
Browse files Browse the repository at this point in the history
Signed-off-by: Carlos Agüero <[email protected]>
  • Loading branch information
caguero authored Aug 31, 2023
1 parent 52167a6 commit ecc91e8
Show file tree
Hide file tree
Showing 3 changed files with 6 additions and 3 deletions.
3 changes: 2 additions & 1 deletion src/systems/physics/EntityFeatureMap_TEST.cc
Original file line number Diff line number Diff line change
Expand Up @@ -25,6 +25,7 @@
#include <gz/physics/Entity.hh>
#include <gz/physics/ForwardStep.hh>
#include <gz/physics/Implements.hh>
#include <gz/physics/InstallationDirectories.hh>
#include <gz/physics/Link.hh>
#include <gz/physics/RemoveEntities.hh>
#include <gz/physics/config.hh>
Expand Down Expand Up @@ -57,7 +58,7 @@ class EntityFeatureMapFixture: public InternalFixture<::testing::Test>
const std::string pluginLib = "gz-physics-dartsim-plugin";

common::SystemPaths systemPaths;
systemPaths.AddPluginPaths({GZ_PHYSICS_ENGINE_INSTALL_DIR});
systemPaths.AddPluginPaths(gz::physics::getEngineInstallDir());

auto pathToLib = systemPaths.FindSharedLibrary(pluginLib);
ASSERT_FALSE(pathToLib.empty())
Expand Down
3 changes: 2 additions & 1 deletion src/systems/physics/Physics.cc
Original file line number Diff line number Diff line change
Expand Up @@ -48,6 +48,7 @@
#include <gz/physics/FeatureList.hh>
#include <gz/physics/FeaturePolicy.hh>
#include <gz/physics/heightmap/HeightmapShape.hh>
#include <gz/physics/InstallationDirectories.hh>
#include <gz/physics/RelativeQuantity.hh>
#include <gz/physics/RequestEngine.hh>

Expand Down Expand Up @@ -806,7 +807,7 @@ void Physics::Configure(const Entity &_entity,
// * Engines installed with gz-physics
common::SystemPaths systemPaths;
systemPaths.SetPluginPathEnv(this->dataPtr->pluginPathEnv);
systemPaths.AddPluginPaths({GZ_PHYSICS_ENGINE_INSTALL_DIR});
systemPaths.AddPluginPaths(gz::physics::getEngineInstallDir());

auto pathToLib = systemPaths.FindSharedLibrary(pluginLib);

Expand Down
3 changes: 2 additions & 1 deletion test/integration/tracked_vehicle_system.cc
Original file line number Diff line number Diff line change
Expand Up @@ -33,6 +33,7 @@
#include <gz/physics/ContactProperties.hh>
#include <gz/physics/FeatureList.hh>
#include <gz/physics/FeaturePolicy.hh>
#include <gz/physics/InstallationDirectories.hh>
#include <gz/physics/config.hh>
#include <gz/plugin/Loader.hh>
#include <gz/utils/ExtraTestMacros.hh>
Expand Down Expand Up @@ -111,7 +112,7 @@ class TrackedVehicleTest : public InternalFixture<::testing::Test>
// modifications)
common::SystemPaths systemPaths;
systemPaths.SetPluginPathEnv("GZ_SIM_PHYSICS_ENGINE_PATH");
systemPaths.AddPluginPaths({GZ_PHYSICS_ENGINE_INSTALL_DIR});
systemPaths.AddPluginPaths(gz::physics::getEngineInstallDir());

auto pathToLib = systemPaths.FindSharedLibrary(*pluginLib);
ASSERT_FALSE(pathToLib.empty())
Expand Down

0 comments on commit ecc91e8

Please sign in to comment.