Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[ign -> gz] CMake functions #1542

Merged
merged 2 commits into from
Jun 18, 2022
Merged

[ign -> gz] CMake functions #1542

merged 2 commits into from
Jun 18, 2022

Conversation

chapulina
Copy link
Contributor

@chapulina chapulina commented Jun 16, 2022 •
edited
Loading

@chapulina
[ign -> gz] CMake functions
93044c5 
Signed-off-by: Louise Poubel <[email protected]>
@chapulina chapulina added the ign to gz Renaming Ignition to Gazebo. label Jun 16, 2022
@chapulina chapulina requested a review from methylDragon June 16, 2022 21:29
@chapulina chapulina mentioned this pull request Jun 16, 2022
Closed
17 tasks
@chapulina chapulina added the 🌱 garden Ignition Garden label Jun 16, 2022
@methylDragon
Copy link
Contributor

gz_add_benchmarks() is not tick-tocked yet from gz-cmake, so it causes the build to break

methylDragon
methylDragon requested changes Jun 17, 2022
View reviewed changes
Copy link
Contributor

@methylDragon methylDragon left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pending gz_add_benchmarks()

@chapulina chapulina mentioned this pull request Jun 17, 2022
Merged
@chapulina chapulina marked this pull request as ready for review June 17, 2022 20:26
@chapulina chapulina requested review from azeey and iche033 as code owners June 17, 2022 20:26
@methylDragon
Copy link
Contributor

@osrf-jenkins run tests please!

@methylDragon methylDragon merged commit 4202625 into main Jun 18, 2022
@methylDragon methylDragon deleted the chapulina/7/cmake_gz branch June 18, 2022 04:13
@j-rivero j-rivero mentioned this pull request Sep 16, 2022
Merged
3 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@methylDragon methylDragon methylDragon approved these changes

@azeey azeey Awaiting requested review from azeey azeey is a code owner

@iche033 iche033 Awaiting requested review from iche033 iche033 is a code owner

Assignees
No one assigned
Labels
🌱 garden Ignition Garden ign to gz Renaming Ignition to Gazebo.
Projects
Core development
Archived in project
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@chapulina @methylDragon