Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Garden: ensure targets exist before referencing #1578

Merged
merged 2 commits into from
Jul 6, 2022

Conversation

scpeters
Copy link
Member

@scpeters scpeters commented Jul 6, 2022

🦟 Bug fix

Attempting to fix the windows build.

Summary

The windows build on Garden has been broken for a while due to an inability to find the ign-common av component. This has been fixed by gazebosim/gz-cmake#271, but there are still cmake issues with the windows build:

CMake Error at test/integration/CMakeLists.txt:167 (target_link_libraries):
  Cannot specify link libraries for target "INTEGRATION_log_system" which is
  not built by this project.

I've added if (TARGET <TARGET_NAME>) checks around each target_* call in test/integration/CMakeLists.txt that was missing it to see if that is enough to fix the windows build.

Checklist

  • Signed all commits for DCO
  • Added tests
  • Updated documentation (as needed)
  • Updated migration guide (as needed)
  • Consider updating Python bindings (if the library has them)
  • codecheck passed (See contributing)
  • All tests passed (See test coverage)
  • While waiting for a review on your PR, please help review another open pull request to support the maintainers

Note to maintainers: Remember to use Squash-Merge and edit the commit message to match the pull request summary while retaining Signed-off-by messages.

Attempting to fix the windows build.

Signed-off-by: Steve Peters <[email protected]>
@scpeters scpeters added the Windows Windows support label Jul 6, 2022
@scpeters scpeters requested a review from chapulina as a code owner July 6, 2022 17:19
@chapulina chapulina added the 🌱 garden Ignition Garden label Jul 6, 2022
Copy link
Contributor

@chapulina chapulina left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM so far, even if it doesn't fix the build it's an improvement

Signed-off-by: Steve Peters <[email protected]>
@scpeters
Copy link
Member Author

scpeters commented Jul 6, 2022

it now fails with linking errors

[2540.391s] ColladaWorldExporter.obj : error LNK2001: unresolved external symbol "__declspec(dllimport) public: bool __cdecl gz::common::MeshManager::HasMesh(class std::basic_string<char,struct std::char_traits<char>,class std::allocator<char> > const &)const " (__imp_?HasMesh@MeshManager@common@gz@@QEBA_NAEBV?$basic_string@DU?$char_traits@D@std@@V?$allocator@D@2@@std@@@Z) [C:\Jenkins\workspace\ign_gazebo-pr-win\ws\build\gz-sim7\src\systems\collada_world_exporter\gz-sim7-collada-world-exporter-system.vcxproj]
[2540.391s] ColladaWorldExporter.obj : error LNK2001: unresolved external symbol "__declspec(dllimport) public: class gz::common::Mesh const * __cdecl gz::common::MeshManager::MeshByName(class std::basic_string<char,struct std::char_traits<char>,class std::allocator<char> > const &)const " (__imp_?MeshByName@MeshManager@common@gz@@QEBAPEBVMesh@23@AEBV?$basic_string@DU?$char_traits@D@std@@V?$allocator@D@2@@std@@@Z) [C:\Jenkins\workspace\ign_gazebo-pr-win\ws\build\gz-sim7\src\systems\collada_world_exporter\gz-sim7-collada-world-exporter-system.vcxproj]
[2540.391s] ColladaWorldExporter.obj : error LNK2001: unresolved external symbol "__declspec(dllimport) public: class gz::common::Mesh const * __cdecl gz::common::MeshManager::Load(class std::basic_string<char,struct std::char_traits<char>,class std::allocator<char> > const &)" (__imp_?Load@MeshManager@common@gz@@QEAAPEBVMesh@23@AEBV?$basic_string@DU?$char_traits@D@std@@V?$allocator@D@2@@std@@@Z) [C:\Jenkins\workspace\ign_gazebo-pr-win\ws\build\gz-sim7\src\systems\collada_world_exporter\gz-sim7-collada-world-exporter-system.vcxproj]
...

attempting a fix in a92c232

@scpeters
Copy link
Member Author

scpeters commented Jul 6, 2022

Build Status https://build.osrfoundation.org/job/ign_gazebo-pr-win/4686/

unstable!!!

@codecov
Copy link

codecov bot commented Jul 6, 2022

Codecov Report

Merging #1578 (6a66b53) into main (a3cbd8c) will decrease coverage by 0.01%.
The diff coverage is 99.31%.

❗ Current head 6a66b53 differs from pull request most recent head a92c232. Consider uploading reports for the commit a92c232 to get more accurate results

@@            Coverage Diff             @@
##             main    #1578      +/-   ##
==========================================
- Coverage   63.62%   63.61%   -0.02%     
==========================================
  Files         330      330              
  Lines       25787    25923     +136     
==========================================
+ Hits        16408    16490      +82     
- Misses       9379     9433      +54     
Impacted Files Coverage Δ
include/gz/sim/EventManager.hh 79.16% <ø> (ø)
include/gz/sim/Util.hh 100.00% <ø> (ø)
include/gz/sim/components/Factory.hh 97.53% <80.00%> (-1.18%) ⬇️
include/gz/sim/EntityComponentManager.hh 100.00% <100.00%> (ø)
include/gz/sim/Link.hh 100.00% <100.00%> (ø)
include/gz/sim/Model.hh 100.00% <100.00%> (ø)
include/gz/sim/SdfEntityCreator.hh 100.00% <100.00%> (ø)
include/gz/sim/Server.hh 100.00% <100.00%> (ø)
include/gz/sim/ServerConfig.hh 100.00% <100.00%> (ø)
include/gz/sim/SystemLoader.hh 100.00% <100.00%> (ø)
... and 132 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 59e66e1...a92c232. Read the comment docs.

@scpeters scpeters merged commit 5336296 into main Jul 6, 2022
@scpeters scpeters deleted the scpeters/fix_garden_cmake branch July 6, 2022 22:13
@j-rivero j-rivero mentioned this pull request Sep 16, 2022
3 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
🌱 garden Ignition Garden Windows Windows support
Projects
Archived in project
Development

Successfully merging this pull request may close these issues.

4 participants