-
Notifications
You must be signed in to change notification settings - Fork 276
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Garden: ensure targets exist before referencing #1578
Conversation
Attempting to fix the windows build. Signed-off-by: Steve Peters <[email protected]>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM so far, even if it doesn't fix the build it's an improvement
Signed-off-by: Steve Peters <[email protected]>
it now fails with linking errors
attempting a fix in a92c232 |
Codecov Report
@@ Coverage Diff @@
## main #1578 +/- ##
==========================================
- Coverage 63.62% 63.61% -0.02%
==========================================
Files 330 330
Lines 25787 25923 +136
==========================================
+ Hits 16408 16490 +82
- Misses 9379 9433 +54
Continue to review full report at Codecov.
|
🦟 Bug fix
Attempting to fix the windows build.
Summary
The windows build on Garden has been broken for a while due to an inability to find the ign-common
av
component. This has been fixed by gazebosim/gz-cmake#271, but there are still cmake issues with the windows build:I've added
if (TARGET <TARGET_NAME>)
checks around eachtarget_*
call intest/integration/CMakeLists.txt
that was missing it to see if that is enough to fix the windows build.Checklist
codecheck
passed (See contributing)Note to maintainers: Remember to use Squash-Merge and edit the commit message to match the pull request summary while retaining
Signed-off-by
messages.