Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ign -> gz : Fix Python bindings #1606

Merged
merged 1 commit into from
Jul 21, 2022
Merged

ign -> gz : Fix Python bindings #1606

merged 1 commit into from
Jul 21, 2022

Conversation

methylDragon
Copy link
Contributor

Part of: gazebo-tooling/release-tools#698

This should fix these failures:

    File "/github/workspace/python/test/testFixture_TEST.py", line 19, in <module>
      from gz.sim import TestFixture, World, world_entity
  ImportError: dynamic module does not define module export function (PyInit_sim)

But I'm explicitly using CI to test if my changes worked.. so.. Draft for now!

Signed-off-by: methylDragon [email protected]

@methylDragon methylDragon added bug Something isn't working 🌱 garden Ignition Garden labels Jul 20, 2022
@methylDragon methylDragon force-pushed the ch3/fix_python_bindings branch from 3f9a517 to 272478c Compare July 20, 2022 23:33
Signed-off-by: methylDragon <[email protected]>
@methylDragon methylDragon force-pushed the ch3/fix_python_bindings branch from 272478c to 8f1a5aa Compare July 21, 2022 00:25
@codecov
Copy link

codecov bot commented Jul 21, 2022

Codecov Report

Merging #1606 (8f1a5aa) into main (a3cbd8c) will decrease coverage by 0.09%.
The diff coverage is 99.25%.

@@            Coverage Diff             @@
##             main    #1606      +/-   ##
==========================================
- Coverage   63.62%   63.53%   -0.10%     
==========================================
  Files         330      330              
  Lines       25787    25912     +125     
==========================================
+ Hits        16408    16462      +54     
- Misses       9379     9450      +71     
Impacted Files Coverage Δ
include/gz/sim/EventManager.hh 79.16% <ø> (ø)
include/gz/sim/Util.hh 100.00% <ø> (ø)
include/gz/sim/components/Serialization.hh 95.55% <ø> (ø)
include/gz/sim/components/Factory.hh 97.53% <80.00%> (-1.18%) ⬇️
include/gz/sim/EntityComponentManager.hh 100.00% <100.00%> (ø)
include/gz/sim/Link.hh 100.00% <100.00%> (ø)
include/gz/sim/Model.hh 100.00% <100.00%> (ø)
include/gz/sim/SdfEntityCreator.hh 100.00% <100.00%> (ø)
include/gz/sim/Server.hh 100.00% <100.00%> (ø)
include/gz/sim/ServerConfig.hh 100.00% <100.00%> (ø)
... and 123 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update ff10109...8f1a5aa. Read the comment docs.

@methylDragon methylDragon marked this pull request as ready for review July 21, 2022 07:12
@methylDragon methylDragon requested a review from chapulina as a code owner July 21, 2022 07:12
@methylDragon methylDragon changed the title Fix Python bindings ign -> gz : Fix Python bindings Jul 21, 2022
@methylDragon methylDragon merged commit bfa24f4 into main Jul 21, 2022
@methylDragon methylDragon deleted the ch3/fix_python_bindings branch July 21, 2022 08:31
@j-rivero j-rivero mentioned this pull request Sep 16, 2022
3 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working 🌱 garden Ignition Garden
Projects
Archived in project
Development

Successfully merging this pull request may close these issues.

2 participants