Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Setup rendering environment before cmake runs #1965

Merged
merged 7 commits into from
Mar 25, 2024

Conversation

azeey
Copy link
Contributor

@azeey azeey commented Apr 17, 2023

🦟 Bug fix

Summary

CMake checks if rendering is available to enable some tests, so the rendering environment needs to be set before CMake runs.

Checklist

  • Signed all commits for DCO
  • Added tests
  • Updated documentation (as needed)
  • Updated migration guide (as needed)
  • Consider updating Python bindings (if the library has them)
  • codecheck passed (See contributing)
  • All tests passed (See test coverage)
  • While waiting for a review on your PR, please help review another open pull request to support the maintainers

Note to maintainers: Remember to use Squash-Merge and edit the commit message to match the pull request summary while retaining Signed-off-by messages.

CMake checks if rendering is available to enable some tests, so the
rendering environment needs to be set before CMake runs.

Signed-off-by: Addisu Z. Taddese <[email protected]>
@github-actions github-actions bot added the 🏰 citadel Ignition Citadel label Apr 17, 2023
@codecov
Copy link

codecov bot commented Apr 17, 2023

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 69.42%. Comparing base (1a61269) to head (2bd262e).
Report is 36 commits behind head on ign-gazebo3.

❗ Current head 2bd262e differs from pull request most recent head 6238454. Consider uploading reports for the commit 6238454 to get more accurate results

Additional details and impacted files
@@               Coverage Diff               @@
##           ign-gazebo3    #1965      +/-   ##
===============================================
- Coverage        77.98%   69.42%   -8.57%     
===============================================
  Files              255      266      +11     
  Lines            15041    18411    +3370     
===============================================
+ Hits             11730    12781    +1051     
- Misses            3311     5630    +2319     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@azeey azeey self-assigned this Apr 17, 2023
azeey added 3 commits April 17, 2023 15:37
Signed-off-by: Addisu Z. Taddese <[email protected]>
Signed-off-by: Addisu Z. Taddese <[email protected]>
Signed-off-by: Addisu Z. Taddese <[email protected]>
@azeey azeey marked this pull request as ready for review May 10, 2023 13:45
@azeey azeey requested a review from mjcarroll as a code owner May 10, 2023 13:45
@azeey azeey added beta Targeting beta release of upcoming collection and removed beta Targeting beta release of upcoming collection labels Jul 31, 2023
@azeey azeey merged commit a3e9f8d into ign-gazebo3 Mar 25, 2024
7 of 8 checks passed
@azeey azeey deleted the azeey/actions_render_env branch March 25, 2024 22:09
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
🏰 citadel Ignition Citadel
Projects
Archived in project
Development

Successfully merging this pull request may close these issues.

2 participants