-
Notifications
You must be signed in to change notification settings - Fork 276
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Setup rendering environment before cmake runs #1965
Conversation
CMake checks if rendering is available to enable some tests, so the rendering environment needs to be set before CMake runs. Signed-off-by: Addisu Z. Taddese <[email protected]>
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## ign-gazebo3 #1965 +/- ##
===============================================
- Coverage 77.98% 69.42% -8.57%
===============================================
Files 255 266 +11
Lines 15041 18411 +3370
===============================================
+ Hits 11730 12781 +1051
- Misses 3311 5630 +2319 ☔ View full report in Codecov by Sentry. |
Signed-off-by: Addisu Z. Taddese <[email protected]>
Signed-off-by: Addisu Z. Taddese <[email protected]>
Signed-off-by: Addisu Z. Taddese <[email protected]>
🦟 Bug fix
Summary
CMake checks if rendering is available to enable some tests, so the rendering environment needs to be set before CMake runs.
Checklist
codecheck
passed (See contributing)Note to maintainers: Remember to use Squash-Merge and edit the commit message to match the pull request summary while retaining
Signed-off-by
messages.