Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix CMake warning in example #2145

Merged
merged 1 commit into from
Sep 13, 2023
Merged

Conversation

azeey
Copy link
Contributor

@azeey azeey commented Sep 13, 2023

🦟 Bug fix

Summary

The add_library call was missing the file extension which caused a CMake warning on CI:

133: CMake Warning (dev) at CMakeLists.txt:13 (add_library):
133:   Policy CMP0115 is not set: Source file extensions must be explicit.  Run
133:   "cmake --help-policy CMP0115" for policy details.  Use the cmake_policy
133:   command to set the policy and suppress this warning.
133: 
133:   File:
133: 
133:     /home/jenkins/workspace/gz_sim-ci-pr_any-jammy-amd64/gz-sim/examples/plugin/hello_world/HelloWorld.cc
133: This warning is for project developers.  Use -Wno-dev to suppress it.

Checklist

  • Signed all commits for DCO
  • Added tests
  • Updated documentation (as needed)
  • Updated migration guide (as needed)
  • Consider updating Python bindings (if the library has them)
  • codecheck passed (See contributing)
  • All tests passed (See test coverage)
  • While waiting for a review on your PR, please help review another open pull request to support the maintainers

Note to maintainers: Remember to use Squash-Merge and edit the commit message to match the pull request summary while retaining Signed-off-by messages.

Signed-off-by: Addisu Z. Taddese <[email protected]>
@azeey azeey requested a review from mjcarroll as a code owner September 13, 2023 19:55
@github-actions github-actions bot added the 🎵 harmonic Gazebo Harmonic label Sep 13, 2023
@codecov
Copy link

codecov bot commented Sep 13, 2023

Codecov Report

Merging #2145 (2f46bbf) into gz-sim8 (d052491) will not change coverage.
Report is 1 commits behind head on gz-sim8.
The diff coverage is n/a.

❗ Current head 2f46bbf differs from pull request most recent head d1dbb42. Consider uploading reports for the commit d1dbb42 to get more accurate results

@@           Coverage Diff            @@
##           gz-sim8    #2145   +/-   ##
========================================
  Coverage    65.45%   65.45%           
========================================
  Files          323      323           
  Lines        30704    30704           
========================================
  Hits         20096    20096           
  Misses       10608    10608           

@azeey azeey merged commit 5577b19 into gazebosim:gz-sim8 Sep 13, 2023
4 checks passed
@azeey azeey added the beta Targeting beta release of upcoming collection label Sep 13, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
beta Targeting beta release of upcoming collection 🎵 harmonic Gazebo Harmonic
Projects
Archived in project
Development

Successfully merging this pull request may close these issues.

2 participants